Revert "syscall: add getifaddrs to os syscalls (#18513)"#18566
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Oct 11, 2021
Merged
Revert "syscall: add getifaddrs to os syscalls (#18513)"#18566mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
This reverts commit fc04382. Signed-off-by: Mike Schore <mike.schore@gmail.com>
mattklein123
approved these changes
Oct 11, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
SGTM, though I would like to get this upstream at some point. cc @junr03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Revert "syscall: add getifaddrs to os syscalls (#18513)"
Additional Description: This reverts commit fc04382. This change broke Envoy Mobile, which contains its own ifaddrs implementation for Android. Ultimately, it could make sense to move this implementation to upstream Envoy, but for now it's useful to keep it in Envoy Mobile where we can iterate with lower friction if needed.
Risk Level: Low
Testing: CI
Signed-off-by: Mike Schore mike.schore@gmail.com