runtime: updates to alpha checks#18552
Merged
alyssawilk merged 4 commits intoenvoyproxy:mainfrom Oct 13, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
tools/code_format/check_format.py
Outdated
| break | ||
|
|
||
| if "//" in line: | ||
| break |
Contributor
There was a problem hiding this comment.
I think this break will result in the alphabetic check being disabled if any comments are added before a flag in the sorted section for any reason. How about changing this check to "// End alphabetically sorted section." and adding that line before the misplaced flags comment. Alternatively, could we sort the existing flags as a way to simplify the alphabetic flags check?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
antoniovicente
approved these changes
Oct 12, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the extra annotations to avoid further errors in sort order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.