tls: make server options available to the handshaker factory#18379
Merged
lizan merged 7 commits intoenvoyproxy:mainfrom Oct 11, 2021
Merged
tls: make server options available to the handshaker factory#18379lizan merged 7 commits intoenvoyproxy:mainfrom
lizan merged 7 commits intoenvoyproxy:mainfrom
Conversation
Use `using` declarations where appropriate, fix local variable naming, use a named constant for the shared magic string. Signed-off-by: Alex Konradi <akonradi@google.com>
This allows the handshaker to detect the run mode (Server::Options::mode) and use that to bypass checks required for serving but not for validation. Signed-off-by: Alex Konradi <akonradi@google.com>
Test that the HandshakerFactoryContext created by the TLS transport socket impl passes through options from the parent transport socket factory context. Signed-off-by: Alex Konradi <akonradi@google.com>
Contributor
Author
|
/cc @ambuc |
Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
@lizan sorry about the noise, looks like CI was having trouble downloading dependencies. Anyway this should be ready for review now. |
lizan
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Make Server::Options available to the SSL handshaker factory
Additional Description:
This allows the handshaker to detect the run mode (
Server::Options::mode) and use thatto bypass checks required for serving but not for validation.
Risk Level: low
Testing: added and ran unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a