fuzz: move the test-thread initialization to fuzz_runner.cc#18535
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Oct 11, 2021
Merged
fuzz: move the test-thread initialization to fuzz_runner.cc#18535mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
|
LGTM |
Contributor
Author
|
/assign-from @envoyproxy/maintainers |
|
@envoyproxy/maintainers assignee is @None |
Contributor
Author
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
mattklein123
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: declaring the TestThread in test/fuzz/main.cc made sense, but it has proved harder to integrate into environments with other custom stuff in main(). It's easier to lazy-static-init it in fuzz_runner.cc which has an integrated hook.
Additional Description:
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a