Skip to content

deps: Bump protobuf -> 3.19.0#18471

Merged
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:bump-google-protobuf
Oct 29, 2021
Merged

deps: Bump protobuf -> 3.19.0#18471
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:bump-google-protobuf

Conversation

@phlax
Copy link
Member

@phlax phlax commented Oct 6, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: deps: Bump protobuf -> 3.19.0
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #18704
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 6, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18471 was opened by phlax.

see: more, trace.

@phlax phlax changed the title deps: Bump protobuf -> 3.18.1 [WIP] deps: Bump protobuf -> 3.18.1 Oct 6, 2021
@phlax phlax marked this pull request as draft October 6, 2021 08:58
@phlax
Copy link
Member Author

phlax commented Oct 7, 2021

updated the patch but its now failing with

ModuleNotFoundError: No module named 'google.api'

running protoxform

@phlax phlax changed the title [WIP] deps: Bump protobuf -> 3.18.1 [WIP] deps: Bump protobuf -> 3.19.0 Oct 21, 2021
@phlax phlax force-pushed the bump-google-protobuf branch 2 times, most recently from 7247182 to c971bd7 Compare October 24, 2021 16:45
@phlax phlax force-pushed the bump-google-protobuf branch 3 times, most recently from 4b26383 to f9f88da Compare October 25, 2021 11:17
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the bump-google-protobuf branch from f9f88da to 08100f0 Compare October 25, 2021 11:44
@phlax phlax changed the title [WIP] deps: Bump protobuf -> 3.19.0 deps: Bump protobuf -> 3.19.0 Oct 25, 2021
@phlax phlax marked this pull request as ready for review October 25, 2021 12:11
@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 26, 2021
@phlax phlax requested a review from htuch October 27, 2021 15:10
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 3b0a4a0 into envoyproxy:main Oct 29, 2021
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 29, 2021
* main: (221 commits)
  deps: Bump `protobuf` -> 3.19.0 (envoyproxy#18471)
  tooling: auto-assign dependency shephards (envoyproxy#18794)
  clang-tidy: Return from diff fun if empty diff (envoyproxy#18815)
  repokitteh: Block PRs pending deps approval (envoyproxy#18814)
  deps: Bump `org_llvm_llvm` -> 12.0.1, `com_github_wavm_wavm` -> 9ffd3e2 (envoyproxy#18747)
  dns resolvers: add All lookup mode (envoyproxy#18464)
  doc: fix link formatting for TLS session_timeout (envoyproxy#18790)
  ext_authz: Set response flag and code details to UAEX when denied (envoyproxy#18740)
  socket options: add support for directly creating ipv4/ipv6 pairs (envoyproxy#18769)
  ecds: make onConfigUpdate generic over filter type (envoyproxy#18061)
  bazel: update CMake instructions in EXTERNAL_DEPS.md (envoyproxy#18799)
  upstream: fix typo in comment (envoyproxy#18798)
  runtime: removing envoy.reloadable_features.grpc_json_transcoder_adhere_to_buffer_limits (envoyproxy#18696)
  bazel: Add CC=clang to clang configuration (envoyproxy#18732)
  fix error request id in the dubbbo local reply (envoyproxy#18741)
  event: assert the case of both read and closed event registered (envoyproxy#18265)
  tcp proxy connect tunneling: improved testing (envoyproxy#18784)
  deps: Bump `protoc-gen-validate` -> 0.6.2 (envoyproxy#18742)
  deps: Bump `rules_pkg` -> ad57589 (envoyproxy#18746)
  bazel: copy .bazelversion for envoy filter examples (envoyproxy#18730)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer release available com_google_protobuf: v3.19.0 (current: v3.18.0)

3 participants