Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
requested changes
Oct 8, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for working on this. Should there be some test for this?
/wait
Member
Author
AFAICT there is no direct testing class for OsSysCalls, but instead the functions are indirectly covered by tests that use them. In this case the test that covers |
added 2 commits
October 8, 2021 15:23
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
previously approved these changes
Oct 8, 2021
phlax
approved these changes
Oct 9, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
on the basis of tacit approval from @mattklein123 - lgtm
goaway
added a commit
to goaway/envoy
that referenced
this pull request
Oct 11, 2021
This reverts commit fc04382. Signed-off-by: Mike Schore <mike.schore@gmail.com>
mattklein123
pushed a commit
that referenced
this pull request
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: syscall - add getifaddrs to os syscalls
Additional Description: formalize getifaddrs into os syscalls.
Risk Level: low
Testing: existing calling code and UT over that code.