Remove envoy.reloadable_features.remove_forked_chromium_url#18585
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Oct 13, 2021
dio:fix-18442
Merged
Remove envoy.reloadable_features.remove_forked_chromium_url#18585mattklein123 merged 3 commits intoenvoyproxy:mainfrom dio:fix-18442
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
dio:fix-18442
Conversation
Fixes #18442 Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
@mattklein123 to merge because DCO is somewhat broken |
Member
|
Awesome!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Remove
envoy.reloadable_features.remove_forked_chromium_urlAdditional description: This removes
source/common/chromium_urldir. cc. @htuchRisk Level: Low
Testing: Updated
Docs Changes: N/A
Release Notes: Added
Platform-Specific Features: N/A
Fixes #18442
Signed-off-by: Dhi Aurrahman dio@rockybars.com