Fix --log-format example to conform to glog format#18808
Merged
snowp merged 1 commit intoenvoyproxy:mainfrom Nov 1, 2021
Merged
Fix --log-format example to conform to glog format#18808snowp merged 1 commit intoenvoyproxy:mainfrom
snowp merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Genta Kamitani <oftn.mofumofu@gmail.com>
|
Hi @genkami, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Contributor
|
This seems fine to me, have you verified that the output is as expected? |
Contributor
Author
|
Yes. I deployed my Envoy with this cmd flag and saw that the logs are parsed correctly like this: {
"jsonPayload": {
"message": "[1][main]initializing epoch 0 (base id=0, hot restart version=11.104)",
"pid": "1"
},
"severity": "INFO",
"sourceLocation": {
"file": "envoy/source/server/server.cc",
"line": "330"
},
...
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to GKE's fluent-bit config, logs should be of the format
^(?<severity>\w)(?<time>\d{4} [^\s]*)\s+(?<pid>\d+)\s+(?<source_file>[^ \]]+)\:(?<source_line>\d+)\]\s(?<message>.*)$. (I found it by runningkubectl describe cm fluentbit-gke-config-v1.0.6 -n kube-systemon my GKE cluster.)The example in doc lacks
\:(?<source_line>\d+)part, so I added it.Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]