bazel: copy .bazelversion for envoy filter examples#18730
bazel: copy .bazelversion for envoy filter examples#18730phlax merged 2 commits intoenvoyproxy:mainfrom
Conversation
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
cc @lizan |
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
oh it's more complicated than this. that repo has a symlink to bazelversion from the submodule of envoy https://github.com/envoyproxy/envoy-filter-example/blob/main/.bazelversion Interesting circular dependency for updating it since the tests here rely on that. I removed that version here now, which might work, but that doesn't feel right either if it actually does reference bazel files from the submodule |
this seems to be a bit of an endemic problem ideally using a third party repo - ie envoy-build-tools should resolve and provide an authoritative version, but atm we seem to be just adding more places where versions are specified im wondering if there is some automation/validation we can add in consuming CI to ensure that there is only one place where version/s need to be specified, and consumers check/copy/enforce versions from whereever we decide is authoritative (<-- as a general approach that we do more often) |
|
(i guess this PR is ~doing what i suggested, but this kinda problem seems to happen with quite a few deps) |
|
yea, I could still see this having issues if that repo actually references bazel files from the submodule, if they also had to be updated to be compatible |
hmm, yep https://github.com/envoyproxy/envoy-filter-example doesnt seem to have much in the way of CI and/or i guess pinning to version/s |
|
/retest |
|
Retrying Azure Pipelines: |
* main: (221 commits) deps: Bump `protobuf` -> 3.19.0 (envoyproxy#18471) tooling: auto-assign dependency shephards (envoyproxy#18794) clang-tidy: Return from diff fun if empty diff (envoyproxy#18815) repokitteh: Block PRs pending deps approval (envoyproxy#18814) deps: Bump `org_llvm_llvm` -> 12.0.1, `com_github_wavm_wavm` -> 9ffd3e2 (envoyproxy#18747) dns resolvers: add All lookup mode (envoyproxy#18464) doc: fix link formatting for TLS session_timeout (envoyproxy#18790) ext_authz: Set response flag and code details to UAEX when denied (envoyproxy#18740) socket options: add support for directly creating ipv4/ipv6 pairs (envoyproxy#18769) ecds: make onConfigUpdate generic over filter type (envoyproxy#18061) bazel: update CMake instructions in EXTERNAL_DEPS.md (envoyproxy#18799) upstream: fix typo in comment (envoyproxy#18798) runtime: removing envoy.reloadable_features.grpc_json_transcoder_adhere_to_buffer_limits (envoyproxy#18696) bazel: Add CC=clang to clang configuration (envoyproxy#18732) fix error request id in the dubbbo local reply (envoyproxy#18741) event: assert the case of both read and closed event registered (envoyproxy#18265) tcp proxy connect tunneling: improved testing (envoyproxy#18784) deps: Bump `protoc-gen-validate` -> 0.6.2 (envoyproxy#18742) deps: Bump `rules_pkg` -> ad57589 (envoyproxy#18746) bazel: copy .bazelversion for envoy filter examples (envoyproxy#18730) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Yan Avlasov <yavlasov@google.com> Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Yan Avlasov <yavlasov@google.com> Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
This file needs to be copied otherwise bazelisk picks whichever current version is out there which could break with any release Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Yan Avlasov <yavlasov@google.com> Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
This file needs to be copied otherwise bazelisk picks whichever current
version is out there which could break with any release
Signed-off-by: Keith Smiley keithbsmiley@gmail.com