Skip to content

config: adjust "gRPC config stream closed" log message#18533

Merged
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
tbarrella:readability
Oct 12, 2021
Merged

config: adjust "gRPC config stream closed" log message#18533
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
tbarrella:readability

Conversation

@tbarrella
Copy link
Copy Markdown
Contributor

@tbarrella tbarrella commented Oct 8, 2021

Commit Message:
config: adjust "gRPC config stream closed" log message

Signed-off-by: Taylor Barrella tabarr@google.com

Additional Description:
Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: Noted minor change
Platform Specific Features: N/A
Fixes #18508

@tbarrella
config: adjust "gRPC config stream closed" log message
5cdd941 
Signed-off-by: Taylor Barrella <tabarr@google.com>
@tbarrella
lowercase
367c296 
Signed-off-by: Taylor Barrella <tabarr@google.com>
@davinci26
Copy link
Copy Markdown
Member

davinci26 commented Oct 11, 2021

/assign-from @envoyproxy/first-pass-reviewers

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Oct 11, 2021

@envoyproxy/first-pass-reviewers assignee is @KBaichoo

🐱

Caused by: a #18533 (comment) was created by @davinci26.

see: more, trace.

@davinci26 davinci26 assigned KBaichoo and davinci26 and unassigned KBaichoo Oct 11, 2021
KBaichoo
KBaichoo approved these changes Oct 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@KBaichoo KBaichoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the change.

@yanavlasov yanavlasov merged commit c35ff41 into envoyproxy:main Oct 12, 2021
@tbarrella tbarrella deleted the readability branch October 12, 2021 18:07
@tbarrella
Copy link
Copy Markdown
Contributor Author

tbarrella commented Oct 13, 2021

/backport

@repokitteh-read-only repokitteh-read-only bot added the backport/review Request to backport to stable releases label Oct 13, 2021
@tbarrella
Copy link
Copy Markdown
Contributor Author

tbarrella commented Oct 27, 2021

Hi @mathetake (or is there a new release manager yet?), is there anything else I should do for this to be backported? Looking at https://github.com/envoyproxy/envoy/blob/main/RELEASES.md#backports it seems these are periodically reviewed and maintainers apply them. @howardjohn requested this because it fixes a regression

@mathetake
Copy link
Copy Markdown
Member

mathetake commented Nov 2, 2021

Hi @mathetake (or is there a new release manager yet?), is there anything else I should do for this to be backported? Looking at https://github.com/envoyproxy/envoy/blob/main/RELEASES.md#backports it seems these are periodically reviewed and maintainers apply them. @howardjohn requested this because it fixes a regression

Sorry I missed the mention.. could you open the Pr against release/v1.20 branch? @tbarrella

@mathetake mathetake added backport/approved Approved backports to stable releases and removed backport/review Request to backport to stable releases labels Nov 2, 2021
tbarrella added a commit to tbarrella/envoy that referenced this pull request Nov 3, 2021
@tbarrella
config: adjust "gRPC config stream closed" log message (envoyproxy#18533
e74aaed 
)

backport of c35ff41

Signed-off-by: Taylor Barrella <tabarr@google.com>
@tbarrella tbarrella mentioned this pull request Nov 3, 2021
Merged
@tbarrella
Copy link
Copy Markdown
Contributor Author

tbarrella commented Nov 3, 2021

@mathetake Thank you, opened #18886

mathetake added a commit that referenced this pull request Nov 4, 2021
@tbarrella @mathetake
config: adjust "gRPC config stream closed" log message (#18533) (#18886)
b16d390 
backport of c35ff41

Signed-off-by: Taylor Barrella <tabarr@google.com>

Co-authored-by: Takeshi Yoneda <takeshi@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KBaichoo KBaichoo KBaichoo approved these changes

@yanavlasov yanavlasov yanavlasov approved these changes

Assignees

@KBaichoo KBaichoo

@davinci26 davinci26

Labels

backport/approved Approved backports to stable releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1.20 Logging shows *first* error message, not *last* error

5 participants

@tbarrella @davinci26 @mathetake @KBaichoo @yanavlasov