health check: remove health_check.immediate_failure_exclude_from_cluster#18556
Merged
mattklein123 merged 3 commits intomainfrom Oct 12, 2021
Merged
health check: remove health_check.immediate_failure_exclude_from_cluster#18556mattklein123 merged 3 commits intomainfrom
mattklein123 merged 3 commits intomainfrom
Conversation
Fixes #18439 Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
davinci26
approved these changes
Oct 12, 2021
Member
davinci26
left a comment
davinci26
left a comment
There was a problem hiding this comment.
thanks, LGTM. Waiting for the CI to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18439
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A