thrift_proxy: Add zone response metrics to thrift upstream requests#18512
Merged
davinci26 merged 9 commits intoenvoyproxy:mainfrom Oct 12, 2021
Merged
thrift_proxy: Add zone response metrics to thrift upstream requests#18512davinci26 merged 9 commits intoenvoyproxy:mainfrom
davinci26 merged 9 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: James Fish <jfish@pinterest.com>
Signed-off-by: James Fish <jfish@pinterest.com>
rgs1
reviewed
Oct 8, 2021
Member
rgs1
left a comment
There was a problem hiding this comment.
Looks good once we get the formatting passing, thanks!
source/extensions/filters/network/thrift_proxy/router/config.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: James Fish <jfish@pinterest.com>
Signed-off-by: James Fish <jfish@pinterest.com>
Signed-off-by: James Fish <jfish@pinterest.com>
Signed-off-by: James Fish <jfish@pinterest.com>
Member
|
@fishcakez almost there, small drop in coverage: |
Signed-off-by: James Fish <jfish@pinterest.com>
Contributor
Author
From the output you shared the drop is due to adding some empty lines, which get reported as 0 counts, so I just deleted 4 of the ones I introduced. |
Member
|
Assigning myself for final review after the thrift folks approve. |
rgs1
reviewed
Oct 11, 2021
docs/root/configuration/other_protocols/thrift_filters/router_filter.rst
Show resolved
Hide resolved
Signed-off-by: James Fish <jfish@pinterest.com>
rgs1
approved these changes
Oct 12, 2021
Member
rgs1
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Over to @davinci26 for final pass & merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add zone response metrics to thrift upstream requests
Additional Description: Add response type/reply type counters and request time per zone pair upstream metrics in the same format as http zone metrics.
Risk Level: low
Testing: unit tests and local deployment
Docs Changes: N/A
Release Notes: Yes, added metrics.
Platform Specific Features: N/A