[compression]: removing enable_compression_without_content_length_header runtime guard#18460
Merged
rojkov merged 3 commits intoenvoyproxy:mainfrom Oct 11, 2021
Merged
[compression]: removing enable_compression_without_content_length_header runtime guard#18460rojkov merged 3 commits intoenvoyproxy:mainfrom
rojkov merged 3 commits intoenvoyproxy:mainfrom
Conversation
…der runtime guard Signed-off-by: Nikita V. Shirokov <tehnerd@tehnerd.com>
tehnerd
force-pushed
the
remove_gzip_guard
branch
from
bd59eb2 to
47bbbcb
Compare
Member
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
Sorry needs a main merge. /wait |
Signed-off-by: Nikita V. Shirokov <tehnerd@tehnerd.com>
Signed-off-by: Nikita V. Shirokov <tehnerd@tehnerd.com>
Contributor
Author
|
sorry @rojkov seems like you will need to do it again, since there were merge conflict w/ upstream and was forced to remerge ;/ |
rojkov
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Removing runtime guard. since we have this code path enabled by default for a while and it seems there are no known issues with it.
Additional Description:
Risk Level: LOW. this runtime guard was enabled by default for 6months
Testing: existing UTs
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
#18435
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]