api: remove v2 dependencies from v3 API protos.#18817
Merged
htuch merged 5 commits intoenvoyproxy:mainfrom Oct 29, 2021
Merged
Conversation
This should reduce the binary size, which is particularly important for Envoy Mobile. Looking at a local opt build with debug symbols, I'm seeing a drop from ~400MB to ~380MB, so maybe 5% saving. Related to envoyproxy#10943 Risk level: Low Testing: bazel query deps to confirm no more v2 API deps. Signed-off-by: Harvey Tuch <htuch@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome! Check CI?
/wait
Member
|
not sure why this has triggered a flake8 error ill investigate further... |
Member
this is the problem we are hitting - or at least the best explanation unrelated to this PR, but the error message is most unhelpful we can either downgrade flake8 package or add a workaround @htuch in the meantime running flake8 directly, shows the problem that will unblock CI |
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
|
CI still seems broken. :( /wait |
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
pushed a commit
that referenced
this pull request
Oct 29, 2021
Fixes issue discussed here #18817 (comment) Signed-off-by: Ryan Northey <ryan@synca.io>
jasonmillerstackpath
pushed a commit
to jasonmillerstackpath/envoy
that referenced
this pull request
Oct 29, 2021
Fixes issue discussed here envoyproxy#18817 (comment) Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce the binary size, which is particularly important for Envoy Mobile. Looking at a
local opt build with debug symbols, I'm seeing a drop from ~400MB to ~380MB, so maybe 5% saving. @Reflejo indicates that optimized Envoy Mobile without symbols is observing ~20% improvement.
Related to #10943
Risk level: Low
Testing: bazel query deps to confirm no more v2 API deps.
Signed-off-by: Harvey Tuch htuch@google.com