Allow to delete mandatory filesystems#2129
Closed
ancorgs wants to merge 6 commits intoagama-project:after-release-beta2from
Closed
Allow to delete mandatory filesystems#2129ancorgs wants to merge 6 commits intoagama-project:after-release-beta2from
ancorgs wants to merge 6 commits intoagama-project:after-release-beta2from
Conversation
ancorgs
force-pushed
the
delete_root_beta2
branch
2 times, most recently
from
0212cb3 to
1bc2d5c
Compare
Pull Request Test Coverage Report for Build 13855195705Details
💛 - Coveralls |
dgdavid
reviewed
Mar 11, 2025
ancorgs
force-pushed
the
delete_root_beta2
branch
2 times, most recently
from
a1d3a02 to
9da2d82
Compare
ancorgs
force-pushed
the
delete_root_beta2
branch
2 times, most recently
from
6748aec to
b8a0dac
Compare
ancorgs
changed the title
ancorgs
force-pushed
the
delete_root_beta2
branch
from
b8a0dac to
c1c86c4
Compare
dgdavid
added a commit
that referenced
this pull request
Mar 20, 2025
This is a re-incarnation of #2129, that was automatically closed by Github. ## Problem Agama does not allow to delete the "/" partition nor the drive containing it. But that was only implemented to hide some limitations of the current UI. In fact, deleting "/" or any other mandatory partition should be allowed. Of course, a proposal without mandatory mount paths is not valid and cannot be computed. But that doesn’t mean the user cannot delete them temporarily in order to create it elsewhere. ## Solution - Detect and properly report when mandatory partitions are missing. - Adapt the UI to not panic (ie. resort to an empty state) when there are configuration errors that can actually be fixed by using the UI. - Allow to delete all partitions (including "/"). - Adapt the "do not use" button of the drives to the new situation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agama does not allow to delete the "/" partition nor the drive containing it.
But that was only implemented to hide some limitations of the current UI. In fact, deleting "/" or any other mandatory partition should be allowed. Of course, a proposal without mandatory mount paths is not valid and cannot be computed. But that doesn’t mean the user cannot delete them temporarily in order to create it elsewhere.
Solution
Screenshots
Now the trash-can icon is there for root as well...
But nothing dramatic happens if the user clicks on it.
Testing