Skip to content

fix(rust): add extension to the "filename" in the disposition header #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 2 commits into from
Mar 12, 2025
Merged

fix(rust): add extension to the "filename" in the disposition header #2151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b876a98
fix(rust): add the extension to filename in disposition
imobachgs Mar 12, 2025
90f6422
doc(rust): update changes files
imobachgs Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions rust/agama-server/src/manager/web.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,15 @@ async fn download_logs() -> impl IntoResponse {
header::CONTENT_TYPE,
HeaderValue::from_static("application/x-compressed-tar"),
);
headers.insert(
header::CONTENT_DISPOSITION,
HeaderValue::from_static("attachment; filename=\"agama-logs\""),
);
if let Some(file_name) = path.file_name() {
let disposition =
format!("attachment; filename=\"{}\"", &file_name.to_string_lossy());
headers.insert(
header::CONTENT_DISPOSITION,
HeaderValue::from_str(&disposition)
.unwrap_or_else(|_| HeaderValue::from_static("attachment")),
);
}
headers.insert(
header::CONTENT_ENCODING,
HeaderValue::from_static(logs::DEFAULT_COMPRESSION.1),
Expand Down
6 changes: 6 additions & 0 deletions rust/package/agama.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Wed Mar 12 13:09:52 UTC 2025 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Set the extension in the disposition "filename" so Chrome uses
the correct name (gh#agama-project/agama#2141).

-------------------------------------------------------------------
Mon Mar 10 12:13:19 UTC 2025 - José Iván López González <jlopez@suse.com>

Expand Down