Merged
Conversation
* changelog: Internal, In-Person Proofing, Centralized utils, types, and hooks * Properly import type definitions
#9057) * add value to prevent autocomplete changelog: User-facing improvements, email address, prevent autofill of email addresses * update autocomplete value * update autocomplete value to be more general * make autocomplete garbage field dynamic * return to `autocomplete: off` * fix up autocomplete on add email only * autocomplete value only off on email show * lintfix
…9078) * LG-10586: Direct users to new SSN entry URL for in-person proofing changelog: Internal, In-Person Proofing, Direct users to new SSN entry URL for in-person proofing * LG-10586: Add redirects to previous in-person SSN routes
Follow-on to #9022 [skip changelog]
This method was added to log exceptions that were raised when trying to validate passwords. This was because an invalid password attempt would raise an encryption error; there was concern that this would cause other exceptions to be missed. This was only relevant when we were encrypting passwords with UAKs. Now that we are not longer using UAKs this method just writes invalid password attempts to production.log. This duplicates what is written to events.log for events where passwords are entered. I could not find anywhere that we are looking at this log line. This commit removes it. [skip changelog]
* Format event definitions on multiple lines * [skip changelog] * Move vendor objects to second line * Restore changes * Move vendors object to second line * Add trailing commas * Move single property to its own line * Format properties and objects on own lines * Move vendor to sub-object line
Currently we do not report MVA timeouts or DLDV connection issues to NewRelic. We do this because this service often has issues and creates a lot of noise. The issues we observe are generally the result of individual MVA timeouts and not issues connecting to the DLDV service. Moreover, during DLDV outages not having DLDV issues reported limits our visibility. This commit removes the constraint that prevents DLDV connection issues from being reported so we have visibility. Since the DLDV service itself is generally reliable this should not result in too much noise. [skip changelog]
This commit updates the identity verification report to include 3 groups of metrics: 1. Metrics on starting the flow 2. Metrics on completion of the in-line flow 3. Metrics on verified users These metrics are broken down further to cover specific scenarios we are concerned about. changelog: Internal, Reporter, The identity verification report was changed to remove a number of metrics and replace them with a number of metrics.
…on (#9086) I tried generating the IdentityVerificationReport in production and learned that we do not have the AWS Cloudwatch SDK in our production group. I addressed the above by adding it and did a quick sweep of dependencies that were in the Gemfile to add things that were missing there. I also removed some unnecessary `require`s where they were being used for things that are already loaded with all the other gems. [skip changelog]
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> changelog: User-Facing Improvements, Partner Dashboard, Compresses syncing service providers
* Add new validation * Add new error text * Add test, and revise current tests for new validation * Revise additional tests * Correct the test name Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com> * Use a proc for validation instead * Remove top level validation for later followup * Fix linting issues * changelog: User-Facing Improvements, In-person proofing, When an address is not read off of the id, tell the user about that problem earlier so they can re-upload id to fix --------- Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com>
* Updating .gitlab-ci.yml for chart name changes and testing * Disabling pivcac deploy on helm chart * Updating internal helm chart for new eks resource naming * Moving gitlab-ci back to internal helm chart * changelog: Internal,Review-Apps,Updating Gitlab-CI for resource name changes in helm-chart
* changelog: Internal, Authentication, Change logging so we can query between mfa at creation vs adding additional mfas * fix rspec * change registration value * enter in analytics events * rubocop * LG-10489: add spec to ensure were tracking what analytics is sent * add additional info to analytics event and fix spec * analytic event fix order sorting
…moving SPs (#9088) * Add a break when there are IPEs that will need to be removed * Apply suggestions from code review changelog: Internal, Cleanup, Add abort when attempting to destroy records with In Person Enrollments associated with it
…essing session (#9082) * fix ordering of confirm_two_factor_authenticated filter in phone controller changelog: Bug Fixes, Identity Verification, Presence of user verified before requesting session for user * test hybrid doc user via sendlink on desktop to access phone step * verify user is logged out * Regression spec - jump to Phone step to confirm it doesn't cause errors * remove test not needed --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* french translation for line is lowercased * add changelog changelog: User-Facing Improvements, IdV, lowercase Linge for French translation
) * Copy and move Location Results components * Point in person search step to newly exported components * changelog: Internal, In-Person Proofing, Move InPersonLocations component * Fix type import * Update app/javascript/packages/address-search/types.d.ts Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> --------- Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>
* Log 'TAP' or 'AUTO' when an image upload fails * Add `acuantCaptureMode` to tests * changelog: Internal, In-Person Proofing, log 'acuantCaptureMode' to tell if all cropping errors are from 'Tap to capture' mode
* Trim leading & trailing white space * create new input handler for zipcode * move trim method to onSearch vars * Add trimStart to check for only spaces * Add zip code error message for pattern mismatch * fix lint issues * changelog: User-Facing Improvements, In-person proofing, Improve validation on PO search fill address form * Tests to check for validation errors * fix lint errors * Add logic to check for valid zipCode length * added validation for address and city * fix linter error * create unique on change events to handles to clean input Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Add event to grab value * delete unused input change handler function * fix lint errors * Add select change event, max length, trim on submission * fix linter issues * remove regex from address and city * fix linter errors * Add validation tests * Clean up duplicate tests, delete unnecessary input on form * fix linter issues * Use regex/pattern to find err for space only input * Update zipcode to handle only 5 digits * modified valid length for zip * Remove zipcode onchange handler * fix linter error * update test * updated test to remove try/catch --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Internal, Log querying, Update default log group name
* only reset rate limit after DocPIIForm also is successful * changelog: Bug Fixes, Identity Verification, Verify that PIIDocForm is also successful when resetting rate limits * feature test to show that address is missing during doc auth * refactor to make credentials errors test reusable * add rate limiting test for invalid credentials * refactor test credentials spec * happy linting * happy linting * happy linting * happy linting * remove unintended file
* Add reCAPTCHA configuration overrides for Canada, Mexico changelog: Upcoming Features, reCAPTCHA, Add default configuration overrides for Canada and Mexico * Update specs for international number * Update specs for international number * Update specs for international number
changelog: Internal, Code Quality, Consolidate code paths for MFA setup
* Move file, re-export * changelog: Internal, In-Person Proofing, Move address search input component into its own file * Rename type; remove leftover exports * Fix naming in spec
* Integrating pivcac in review-app deploy * Allowing PIVCAC app values to be overwritten by ENV * Adding PIVCAC overrides to IDP/WORKER review-app deploy * Adding new ENVs for PIVCAC connection to Dockerfile * Attempting new PIVCAC address for IDP/Worker review-app deployment * Troubleshooting PIVCAC redirect * Troubleshooting pivcac integration with review-apps * Adding test of tagging main container after merge * Changing main tagging strategy to build main * Fixing typo * Troubleshooting trigger rules * Troubleshooting * Troubleshooting * troubleshooting * Troubleshooting workflow triggers for review-app * troubleshooting * troubleshooting * troubleshooting * troubleshooting * troubleshooting * Troubleshooting * Testing image tagging * Testing image tagging * Testing image tagging * Implementing main image tagging and launching review-app with PIVCAC main image * Changing variable name * Improvements, Review-Apps, Integrating PIVCAC into review-apps * changelog: Improvements, Review-Apps, Integrating PIVCAC into review-apps
…sSearch into package (#9101)
* Replace flow session error with flash error in link sent controller spec expectation Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Replace flow session error with flash Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Remove unused references to flow_session error_message Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Remove unused flow_session error_message references in getting started show view Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * [skip changelog] * Remove flow session in locals in agreement and getting_started controllers Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> --------- Co-authored-by: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
…lytics events (#9094) * Add GettingStarted A/B test bucket to image upload vendor submitted event * Add bucket to 'Doc Auth Warning' event * Add A/B test buckets to more image upload form events * Update analytics_spec changelog: Internal, Logging, Add GettingStarted AB test bucket to image upload events * Add A/B test bucket to image_uploads_controller specs * Document changes in analytics_events --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov> Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov>
[skip changelog]
* changelog: Internal, In-Person Proofing, Address Search version 2.0.0 * Make prop optional * Revert "Make prop optional" This reverts commit d7c2b76.
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.41 to 1.10.43. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.41...v1.10.43) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix reCAPTCHA add phone fallback links changelog: Upcoming Features, Phone Fraud Protection, Show correct links for phone challenge fallback when adding to existing account * Make helper method available everywhere spam_protection used
aduth
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features