Skip to content

Add reCAPTCHA configuration overrides for Canada, Mexico#9066

Merged
aduth merged 4 commits intomainfrom
aduth-recaptcha-ca-mx
Aug 28, 2023
Merged

Add reCAPTCHA configuration overrides for Canada, Mexico#9066
aduth merged 4 commits intomainfrom
aduth-recaptcha-ca-mx

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 23, 2023

🛠 Summary of changes

Adds default reCAPTCHA score threshold configuration overrides for Canada and Mexico, so that they behave consistently across deployed environments.

📜 Testing Plan

Enable reCAPTCHA locally with configuration in config/application.yml:

phone_recaptcha_score_threshold: 0.5
  1. Go to http://localhost:3000
  2. Create an account
  3. At MFA setup selection, choose phone
  4. Enter a Canadian or Mexican phone number, e.g. 3065550100
  5. In the "reCAPTCHA score" field (internal only), enter a number lower than the threshold defined in configuration, e.g. 0.4 if using the above-defined threshold
  6. Submit the page
  7. Observe that you pass successfully to the "Enter your one-time code" screen

@aduth aduth requested a review from a team August 23, 2023 13:35
Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

changelog: Upcoming Features, reCAPTCHA, Add default configuration overrides for Canada and Mexico
@aduth aduth force-pushed the aduth-recaptcha-ca-mx branch from 0a76488 to d61c278 Compare August 23, 2023 15:07
@aduth aduth merged commit b729df3 into main Aug 28, 2023
@aduth aduth deleted the aduth-recaptcha-ca-mx branch August 28, 2023 17:02
@mdiarra3 mdiarra3 mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants