LG-10780 Update the metrics in the identity verification report#9083
Merged
LG-10780 Update the metrics in the identity verification report#9083
Conversation
This commit updates the identity verification report to include 3 groups of metrics: 1. Metrics on starting the flow 2. Metrics on completion of the in-line flow 3. Metrics on verified users These metrics are broken down further to cover specific scenarios we are concerned about. changelog: Internal, Reporter, The identity verification report was changed to remove a number of metrics and replace them with a number of metrics.
Contributor
Author
|
@zachmargolis: I just added the |
zachmargolis
approved these changes
Aug 24, 2023
| @@ -67,12 +84,15 @@ | |||
| describe '#data' do | |||
| it 'counts unique users per event as a hash' do | |||
| expect(report.data).to eq( | |||
Contributor
There was a problem hiding this comment.
in hindsight, maybe we could have had a separate hash for the derived numbers (results module) but in the end same same
jmhooper
deleted the
jmhooper-change-the-identity-verified-background-job
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the identity verification report to include 3 groups of metrics:
These metrics are broken down further to cover specific scenarios we are concerned about.