Skip to content

LG-10586: Direct users to new SSN entry URL for in-person proofing#9078

Merged
NavaTim merged 2 commits intomainfrom
tbradley/lg-10586-update-ssn-url
Aug 24, 2023
Merged

LG-10586: Direct users to new SSN entry URL for in-person proofing#9078
NavaTim merged 2 commits intomainfrom
tbradley/lg-10586-update-ssn-url

Conversation

@NavaTim
Copy link
Contributor

@NavaTim NavaTim commented Aug 23, 2023

🎫 Ticket

LG-10586

🛠 Summary of changes

  • Direct users to new SSN entry URL for in-person proofing
  • Add deprecation warning to the previous routes
    • This was intentionally left in for this pull request in order to prevent issues for users who are active during the release process. The routes can be removed after this change is deployed.
    • Recommended redirects were modified to ensure that requests are processed seamlessly

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Complete in-person proofing up to SSN step with address matching ID
  • Verify that URL ends with /verify/in_person/ssn
  • Submit SSN form
  • Verify that SSN update succeeded on Verify Info page
  • Complete in-person proofing up to SSN step with address not matching ID
  • Verify that URL ends with /verify/in_person/ssn
  • Submit SSN form
  • Verify that SSN update succeeded on Verify Info page
  • Edit address from Verify Info step
  • Verify that URL ends with /verify/in_person/ssn
  • Complete in-person proofing up to SSN step
  • Manually change URL to /verify/in_person_proofing/ssn
  • Check that URL gets updated to /verify/in_person/ssn
  • Modify form to submit to /verify/in_person_proofing/ssn using browser inspector
  • Open network tab of inspector and select "Preserve log"
  • Submit SSN form
  • Check that network tab shows the a 307 status code for the POST to /verify/in_person_proofing/ssn
  • Check that network tab shows the a 302 status code for a subsequent POST to /verify/in_person/ssn
  • Check that SSN update was successful on Verify Info page

changelog: Internal, In-Person Proofing, Direct users to new SSN entry URL for in-person proofing
@NavaTim NavaTim requested review from a team and JackRyan1989 and removed request for JackRyan1989 August 23, 2023 23:40
@gina-yamada
Copy link
Contributor

gina-yamada commented Aug 24, 2023

  • Complete in-person proofing up to SSN step with address matching ID
  • Verify that URL ends with /verify/in_person/ssn
  • Submit SSN form
  • Verify that SSN update succeeded on Verify Info page
  • Complete in-person proofing up to SSN step with address not matching ID
  • Verify that URL ends with /verify/in_person/ssn
  • Hit Cancel but the picked No, keep going- redirected back to /verify/in_person/ssn
  • Submit SSN form
  • Verify that SSN update succeeded on Verify Info page
  • Edit address from Verify Info step
  • Verify that URL ends with /verify/in_person/ssn
  • Complete in-person proofing up to SSN step
  • Manually change URL to /verify/in_person_proofing/ssn
  • Check that URL gets updated to /verify/in_person/ssn
  • Modify form to submit to /verify/in_person_proofing/ssn using browser inspector
  • Open network tab of inspector and select "Preserve log"
  • Submit SSN form
  • Check that network tab shows the a 307 status code for the POST to /verify/in_person_proofing/ssn
  • Check that network tab shows the a 302 status code for a subsequent POST to /verify/in_person/ssn
Screenshot 2023-08-24 at 8 45 54 AM
  • Check that SSN update was successful on Verify Info page
  • Once on /verify/in_person/ssn for first time, hit Cancel but the picked No, keep going- redirected back to /verify/in_person/ssn
  • No instances of idv_in_person_proofing_ssn_url found
  • Hit Remote flow SSN page /verify/ssn after uploading ID to pass proofing successfully

@NavaTim NavaTim merged commit 968b49e into main Aug 24, 2023
@NavaTim NavaTim deleted the tbradley/lg-10586-update-ssn-url branch August 24, 2023 15:13
@mdiarra3 mdiarra3 mentioned this pull request Aug 29, 2023

get '/in_person_proofing/ssn' => 'in_person/ssn#show'
put '/in_person_proofing/ssn' => 'in_person/ssn#update'
# DEPRECATION NOTICE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NavaTim Can these be removed now, since these changes have been deployed in production?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the deprecated routes can be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NavaTim Can you take care of cleaning them up? Or is this captured in a ticket somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work on the FSM is being deprioritized for the moment, but I can make sure this is captured in a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants