10301: Publish new address search version#9103
Merged
allthesignals merged 3 commits intomainfrom Aug 28, 2023
Merged
Conversation
NavaTim
reviewed
Aug 28, 2023
| onFoundLocations={(locations) => { | ||
| setLocationResults(locations); | ||
| onFoundLocations(locations); | ||
| onFoundLocations && onFoundLocations(locations); |
Contributor
There was a problem hiding this comment.
We should test (with an automated unit test) that this prop is actually optional and include the type(s) in the function declaration.
Contributor
Author
There was a problem hiding this comment.
Ah yes. I'll remove this and do it in a later PR. I shouldn't have added a rider when this PR is only meant to bump version!
Contributor
Author
There was a problem hiding this comment.
Because I'll also need to add a proper interface definition
This reverts commit d7c2b76.
NavaTim
approved these changes
Aug 28, 2023
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
Major change: publish new version of Address Search.
Rider: makeonFoundLocationsprop optional.📜 Testing Plan