Retire log_password_verification_failure#9084
Merged
Conversation
This method was added to log exceptions that were raised when trying to validate passwords. This was because an invalid password attempt would raise an encryption error; there was concern that this would cause other exceptions to be missed. This was only relevant when we were encrypting passwords with UAKs. Now that we are not longer using UAKs this method just writes invalid password attempts to production.log. This duplicates what is written to events.log for events where passwords are entered. I could not find anywhere that we are looking at this log line. This commit removes it. [skip changelog]
zachmargolis
approved these changes
Aug 24, 2023
mitchellhenke
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was added to log exceptions that were raised when trying to validate passwords. This was because an invalid password attempt would raise an encryption error; there was concern that this would cause other exceptions to be missed. This was only relevant when we were encrypting passwords with UAKs.
Now that we are not longer using UAKs this method just writes invalid password attempts to production.log. This duplicates what is written to events.log for events where passwords are entered.
I could not find anywhere that we are looking at this log line. This commit removes it.