Merged
Conversation
changelog: Upcoming Features, Phone Fraud Protection, Show correct links for phone challenge fallback when adding to existing account
mdiarra3
approved these changes
Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where the reCAPTCHA fallback screen shows incorrect links when adding a phone number to an existing account.
This was an unintended side-effect of the phone consolidation in #8966, since the links were controlled by distinct logic in the two controllers, where one would provide
localsvalue to the view to render a link to "Choose another authentication method":identity-idp/app/controllers/users/phones_controller.rb
Line 27 in c068dfb
identity-idp/app/controllers/users/phone_setup_controller.rb
Line 38 in c068dfb
There was not sufficient regression coverage for this behavior, hence why it was not caught previously.
📜 Testing Plan
+610491570006and assign a score0.4+610491570156and assign a score0.4👀 Screenshots