LG-10753 Add GettingStarted A/B test buckets to some image upload analytics events#9094
Merged
soniaconnolly merged 7 commits intomainfrom Aug 28, 2023
Conversation
…vent Co-authored-by: Douglas Price <douglas.price@gsa.gov>
|
|
||
| def getting_started_ab_test_analytics_bucket | ||
| { | ||
| getting_started_ab_test_bucket: |
Contributor
There was a problem hiding this comment.
can we document these in analytics_events.rb?
Contributor
Author
There was a problem hiding this comment.
Added, even though these are intended to be temporary.
soniaconnolly
requested review from
a team and
charleyf
and removed request for
a team
Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov>
soniaconnolly
deleted the
sonia-lg-10753-ab-test-buckets-in-frontend-image-analytics
branch
Merged
Contributor
|
I'm late reviewing this, but it looks good to me. 👍🏻 Thanks for reaching out to Timnit about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10753
🛠 Summary of changes
To continue investigating GettingStarted A/B test differences in Doc Auth success rates, add the A/B test bucket to analytics events in ApiImageUploadForm
Note: Looked at adding the bucket to the Frontend events, but got bogged down with getting access to the uuid that's used as the GettingStarted bucket discriminator, and backed out.
📜 Testing Plan