LG-10301: Move and rename AddressSearch component.#9100
Merged
allthesignals merged 4 commits intomainfrom Aug 28, 2023
Merged
Conversation
allthesignals
changed the title
allthesignals
force-pushed
the
wmg/10301-combine-results-components
branch
from
8a2ff0e to
f6c174e
Compare
allthesignals
force-pushed
the
wmg/10301-combine-results-components
branch
from
f6c174e to
7c1d632
Compare
tomas-nava
approved these changes
Aug 28, 2023
Contributor
tomas-nava
left a comment
tomas-nava
left a comment
There was a problem hiding this comment.
approve! with naming suggestion
I tested locally and successfully searched for locations using the live ArcGIS & USPS APIs.
| import type { SetupServer } from 'msw/node'; | ||
| import { SWRConfig } from 'swr'; | ||
| import AddressSearch from '.'; | ||
| import AddressSearch from './address-input'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import AddressSearch from './address-input'; | |
| import AddressInput from './address-input'; |
This works because it lets you assign any name to the default export from address-input, but shouldn't it be AddressInput? (here and two places in the body of the test)
Contributor
Author
There was a problem hiding this comment.
Yes! I missed that. Thank youuuuu
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
Moves the AddressSearch component into its own components file. Renames this component to AddressInput to more closely reflect what it actually is.
This change makes way for the full AddressSearch component (which includes the results display).
📜 Testing Plan
make run, force the IPP flow, check that address search returns results.