Skip to content

LG-10301: Move IPP Address Search results components into package#9085

Merged
allthesignals merged 5 commits intomainfrom
wmg/9164-absorb-location-results-components
Aug 25, 2023
Merged

LG-10301: Move IPP Address Search results components into package#9085
allthesignals merged 5 commits intomainfrom
wmg/9164-absorb-location-results-components

Conversation

@allthesignals
Copy link
Contributor

@allthesignals allthesignals commented Aug 24, 2023

🎫 Ticket

Move <InPersonLocations/> and other components into the address search package. This is another refactor/reorg step. No features are added.

🛠 Summary of changes

Three things are happening here:

  1. I move all <InPersonLocations /> and downstream components (<LocationCollection/>, <LocationCollectionItem />) type definitions into the address-search types definition file.
  2. Moved <InPersonLocations /> and downstream components (<LocationCollection/>, <LocationCollectionItem />) from @18f/document-capture to @18f/address-search package
  3. Update affected imports accordingly.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Spot check locally. This is a refactor so tests should capture issues.

@allthesignals allthesignals force-pushed the wmg/9164-absorb-location-results-components branch from c6e0d0b to e7ab458 Compare August 24, 2023 18:39
@allthesignals allthesignals force-pushed the wmg/9164-absorb-location-results-components branch from 549ce89 to c7f24f6 Compare August 24, 2023 19:23
@allthesignals allthesignals requested review from a team and NavaTim August 25, 2023 15:56
@gina-yamada
Copy link
Contributor

gina-yamada commented Aug 25, 2023

@allthesignals When I test locally (and hit api) with several real addresses, I keep hitting no post offices found in 50 miles on your branch. I don't think everything is wired up correctly. (It does work display/return addresses when I use mock data tho). I also notice that the address I entered is not what is displayed in the text below. Reach out on Slack if you want me to demo.

Screenshot 2023-08-25 at 10 17 25 AM

@allthesignals
Copy link
Contributor Author

@gina-yamada and I looked into this and it seemed to have to do with an issue with local env configuration. The arcgis mock fallback was enabled, but the USPS fallback wasn't, meaning the arcgis mock was sending junk addresses (regardless of input) to USPS, which USPS rightly kicked back by returning no results.

@NavaTim NavaTim changed the title LG-9168: Move IPP Address Search results components into package LG-10301: Move IPP Address Search results components into package Aug 25, 2023
Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>
@allthesignals allthesignals merged commit 086be02 into main Aug 25, 2023
@allthesignals allthesignals deleted the wmg/9164-absorb-location-results-components branch August 25, 2023 19:01
@mdiarra3 mdiarra3 mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants