LG-10301: Move IPP Address Search results components into package#9085
Merged
allthesignals merged 5 commits intomainfrom Aug 25, 2023
Merged
LG-10301: Move IPP Address Search results components into package#9085allthesignals merged 5 commits intomainfrom
allthesignals merged 5 commits intomainfrom
Conversation
c6e0d0b to
e7ab458
Compare
549ce89 to
c7f24f6
Compare
Contributor
|
@allthesignals When I test locally (and hit api) with several real addresses, I keep hitting no post offices found in 50 miles on your branch. I don't think everything is wired up correctly. (It does work display/return addresses when I use mock data tho). I also notice that the address I entered is not what is displayed in the text below. Reach out on Slack if you want me to demo. |
Contributor
Author
|
@gina-yamada and I looked into this and it seemed to have to do with an issue with local env configuration. The arcgis mock fallback was enabled, but the USPS fallback wasn't, meaning the arcgis mock was sending junk addresses (regardless of input) to USPS, which USPS rightly kicked back by returning no results. |
NavaTim
approved these changes
Aug 25, 2023
Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎫 Ticket
Move
<InPersonLocations/>and other components into the address search package. This is another refactor/reorg step. No features are added.🛠 Summary of changes
Three things are happening here:
<InPersonLocations />and downstream components (<LocationCollection/>,<LocationCollectionItem />) type definitions into the address-search types definition file.<InPersonLocations />and downstream components (<LocationCollection/>,<LocationCollectionItem />) from @18f/document-capture to @18f/address-search package📜 Testing Plan
Provide a checklist of steps to confirm the changes.