LG-10656: Start moving address_edited out of flow_session#9022
Merged
LG-10656: Start moving address_edited out of flow_session#9022
Conversation
Really basic as there wasn't one before [skip changelog]
matthinz
commented
Aug 16, 2023
| @@ -0,0 +1,82 @@ | |||
| require 'rails_helper' | |||
|
|
|||
| RSpec.describe Idv::AddressController do | |||
Contributor
Author
There was a problem hiding this comment.
We didn't have a controller spec for this previously, so I added an extremely minimal one.
soniaconnolly
approved these changes
Aug 17, 2023
| end | ||
| end | ||
|
|
||
| describe '#update' do |
Contributor
There was a problem hiding this comment.
Recommend adding a spec for update logging an analytics event too. (Thank you for adding a controller spec! Maybe we can delete some things out of the feature spec?)
matthinz
added a commit
that referenced
this pull request
Aug 23, 2023
Follow-on to #9022 [skip changelog]
matthinz
added a commit
that referenced
this pull request
Aug 24, 2023
Follow-on to #9022 [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10656
🛠 Summary of changes
Start moving
address_editedfromflow_sessiontoidv_session. This is the first of two PRs, enabling writing to both locations and reading from either. After this is deployed, a subsequent PR will remove reads and writes toflow_session['address_edited']