LG-10452 Improve Validation on Full Address Form#9008
Merged
gina-yamada merged 39 commits intomainfrom Aug 28, 2023
Merged
Conversation
gina-yamada
commented
Aug 15, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Show resolved
Hide resolved
gina-yamada
commented
Aug 15, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Show resolved
Hide resolved
gina-yamada
commented
Aug 15, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Outdated
Show resolved
Hide resolved
…dation on PO search fill address form
…52-ImproveValidationOnFullAddressForm
gina-yamada
commented
Aug 16, 2023
...nt-capture/components/in-person-location-full-address-entry-post-office-search-step.spec.tsx
Outdated
Show resolved
Hide resolved
…52-ImproveValidationOnFullAddressForm
gina-yamada
commented
Aug 17, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Show resolved
Hide resolved
…52-ImproveValidationOnFullAddressForm
aduth
reviewed
Aug 18, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Contributor
Author
|
@aduth Thanks for the review! Good point about just having unique change handler functions to handle each input rather than if/else logic. |
…52-ImproveValidationOnFullAddressForm
NavaTim
reviewed
Aug 22, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Show resolved
Hide resolved
gina-yamada
commented
Aug 23, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Outdated
Show resolved
Hide resolved
gina-yamada
commented
Aug 24, 2023
…52-ImproveValidationOnFullAddressForm
Contributor
Author
|
Other than translations- this PR can be reviewed/tested again. Thank you! |
NavaTim
reviewed
Aug 24, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.tsx
Outdated
Show resolved
Hide resolved
…52-ImproveValidationOnFullAddressForm
…52-ImproveValidationOnFullAddressForm
NavaTim
reviewed
Aug 25, 2023
app/javascript/packages/document-capture/components/in-person-full-address-search.spec.tsx
Outdated
Show resolved
Hide resolved
NavaTim
approved these changes
Aug 26, 2023
…52-ImproveValidationOnFullAddressForm
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10452 Improve validation on PO search full address form
🛠 Summary of changes
Improved Validation on Full Address Form:
📜 Testing Plan
in_person_full_address_entry_enabledto true in application.yml (if testing locally)-- All updates made to the Find a participating Post Office long form at/verify/document_capture#location. You will know you are on the long form if you can see an input field for Address, City, ZIP Code, and a drop down box for State. You will be taken there automatically after you fail proofing if you choose In Person Proofing and the flag in step 1 has been turned on.📷 Screenshots