Skip to content

Lg 10556 move error message out of flow session 1 of 2#9095

Merged
kbighorse merged 7 commits intomainfrom
LG-10556-Move-error_message-out-of-flow_session
Aug 28, 2023
Merged

Lg 10556 move error message out of flow session 1 of 2#9095
kbighorse merged 7 commits intomainfrom
LG-10556-Move-error_message-out-of-flow_session

Conversation

@kbighorse
Copy link
Contributor

@kbighorse kbighorse commented Aug 25, 2023

🎫 Ticket

LG-10556

🛠 Summary of changes

This PR continues the work to remove the Flow State Machine. It replaces uses of the flow_session for errors with flash.

There will be a follow-up PR to remove code that displays flow_session error messages to the user.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Create account, start IDV
  • On agreement step, try to continue without checking the box
  • Expected result: see error under checkbox
  • check box, continue to hybrid handoff
  • On hybrid handoff, send link enough times to get rate limited, i.e. 6
  • Expected result: see error on page in flash messages
  • Create account, start IDV
  • Choose hybrid flow
  • Open /test/telephony in a new incognito window
  • Visit hybrid link
  • Cancel document upload
  • Expected result: see error on link sent page in flash messages

kbighorse and others added 4 commits August 25, 2023 11:51
…pec expectation

Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
…d show view

Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
@kbighorse kbighorse changed the title Lg 10556 move error message out of flow session Lg 10556 move error message out of flow session 1 of 2 Aug 25, 2023
@kbighorse kbighorse requested review from a team, jmhooper and matthinz August 25, 2023 22:35
…llers

Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and saw the flash messages when rate limited on sending links in HybridHandoff, and on canceling document capture from hybrid flow on LinkSent page.

Did not see the message on Agreement page with js turned off (doesn't show up in dev, either), but leaving that component to delete in the followup PR.

@kbighorse kbighorse merged commit 1f6fb26 into main Aug 28, 2023
@kbighorse kbighorse deleted the LG-10556-Move-error_message-out-of-flow_session branch August 28, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants