Skip to content

LG-10489: Allow queryable logging for MFA setup pages#9016

Merged
mdiarra3 merged 10 commits intomainfrom
LG-10489-switch-logging-adding-vs-registration
Aug 25, 2023
Merged

LG-10489: Allow queryable logging for MFA setup pages#9016
mdiarra3 merged 10 commits intomainfrom
LG-10489-switch-logging-adding-vs-registration

Conversation

@mdiarra3
Copy link
Contributor

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-10489

🛠 Summary of changes

This makes use of the method in_multi_mfa_selection_flow? to allow us to search different different MFA setup interactions by users in new account creation flow, vs adding additional MFA options

…etween mfa at creation vs adding additional mfas
@mdiarra3 mdiarra3 requested a review from a team August 16, 2023 18:36
@aduth
Copy link
Contributor

aduth commented Aug 17, 2023

I like the idea of using the multi-select setup flag. One thing I wonder is if we'll allow users to re-enter this flow in the future (e.g. LG-10011, LG-8560, LG-10022), will we have a way to distinguish MFA actions made during the initial account creation?

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 May need to rebase to resolve the lint error.

@mdiarra3 mdiarra3 merged commit f57d5ec into main Aug 25, 2023
@mdiarra3 mdiarra3 deleted the LG-10489-switch-logging-adding-vs-registration branch August 25, 2023 15:09
@mdiarra3 mdiarra3 mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants