LG-10289: Fix cropping error message#8849
Conversation
[Ticket](https://cm-jira.usa.gov/browse/LG-10289) Before this change, when the camera cropping failed in the SDK, the user would get a `Camera failed to start, please try again.` error message. This is confusing because to get to the cropping failure, the user's camera would have had to start. In the case of a cropping error, we want to give a general error message instead.
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Left a question, but looks good 👍
| ); | ||
|
|
||
| initialize({ | ||
| start: sinon.stub().callsArgWithAsync(1, undefined, 'start-fail-code'), |
There was a problem hiding this comment.
Are these parameters accurate for what is sent when a crop error occurs?
There was a problem hiding this comment.
Hi @aduth, I am responding to feedback for this PR because Brittany will be out of office for a bit. Do you happen to know how to trigger a crop error? I wanted to follow up on your question. Thanks!
There was a problem hiding this comment.
I'm not aware of how to trigger it. Part of the reason for the question was trying to understand where in the Acuant source this actually occurs, since the other error expected types were originally sourced by following all of the failure paths.
|
Just posting this for visibility, @charleyf is going to take over this ticket now that he is back from being OOO and Brittany is OOO. He will probably start a new PR. |
|
This work has been done in #8860. |
night-jellyfish
deleted the
brittany/lg-10289-fix-cropping-error-message
branch
3 participants
🎫 Ticket
LG-10289
🛠 Summary of changes
Before this change, when the camera cropping failed in the SDK, the user
would get a
Camera failed to start, please try again.error message.This is confusing because to get to the cropping failure, the user's
camera would have had to start. In the case of a cropping error, we want
to give a general error message instead.
📜 Testing Plan