LG-10828 rate limit doc auth when credentials validation fails#9092
Merged
LG-10828 rate limit doc auth when credentials validation fails#9092
Conversation
…s also successful when resetting rate limits
amirbey
changed the title
amirbey
changed the title
soniaconnolly
approved these changes
Aug 28, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Confirmed rate limiting behavior. Also when I submitted a good proofing.yml on the 5th attempt, it let me go forward.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10828
🛠 Summary of changes
Reset doc_auth rate limiter after successful 3rd party doc auth verification and successful PIIDocForm validation.
###Why
Current implementation resets only after successfull 3rd party verification but should also include successful PIIDocForm validation.
📜 Testing Plan