Merged
Conversation
* handle a malformed response body from ArcGIS service * return 422 instead of 400 on ArcGIS errors * add new test for invalid token changelog: Internal, In-person proofing, Handle a malformed response body from ArcGIS service
* Remove references to flow_session[:document_capture_session_uuid] Following up on #8906, remove references to the flow_session variable [skip changelog] * Remove flow_session from CaptureDocStatusController Barcode attention stuff is stored in IdvSession now, so this should be ok?
* add Acuant SDK 11.9.0 files * delete sdk files we don't use * change functions to match acuant v11.9.0 * expect camelcased cardType * WIP support both sdk versions for a/b testing * support both acuant sdk v8 and v9 * transition from sdk 11.9.0 to 11.9.1 * changelog: User-facing Improvements, Identity verification, Update Acuant SDK to 11.9.1 * support cardtype/cardType * debug acuant camera spec * fix failing specs * fix build * remove comment * refactor to create LegacyAcuantSuccessResponse * attempt to make getActualAcuantCameraUI work for both 11.8.2 and 11.9.1 * WIP add test for 11.8.2 sdk version * first attempt at making a start function compatible with both versions * implement start for sdk 11.8.2 and 11.9.1 * add more tests
We are working on migrating to a KMS key that supports encryption and decryption across regions. To enable this move we are changing the application to encrypt PII and passwords with both a multi-region and single-region key during the migraiton. This commit changes the app to encrypt passwords with the single-region key and the multi-region key when the `aws_kms_multi_region_write_enabled` flag is set. [skip changelog]
* changelog: Internal, Authentication, LG-10743 mark time as unix * unix fix 2 * use unix time in milliseconds * rubocop fix * fix otp verification form
…ith no vulnerabilities (#8978)
* update step indicator strings in es and fr * changelog: User-Facing Improvements, Step indicator, update es and fr translations
* changelog: Internal, Analytics, Add missing analytics events for account pages * fix lint * add nil-safe operator * revert presenter * revert presenter * add method to get referring url for backup code edit * working on spec coverage for logged events * add request_came_from to expected hash * fix lint
[skip changelog]
changelog: Internal, Analytics, Format analytics timestamps for filtering
* Sync React docs / implementation with usage changelog: Internal, Code Quality, Remove unused code * Restore ValidatedField implementation
changelog: Internal, Performance, Load analytics script asynchronously to improve page load
Improve error messages for cancelled mfa, security key changelog: User-Facing Improvements, Authentication, Update error messages related to security key
* Prevent MFA setup validation error from persisting changelog: Bug Fixes, MFA Setup, Fix issue where missing selection error message lingered longer than expected * Add regression spec
changelog: Internal, URL Redirects, Remove usage of outdated URLs
[skip changelog]
* Log user authentication status when logging SAML Auth Request changelog: Internal, Logging, Log user authentication status when logging SAML Auth Request * fix spec
* Data pull script uuid-export spec fixes [skip changelog] * removing order
changelog: Internal, Dependencies, Update Rails gem
* merge changes from other developers * include a missed field in enrollment list * fix lint issues * changelog: Internal, IPP Enrollments, prevent InPersonEnrollment from appearing in two batches * changelog: Internal, IPP Enrollments, prevent InPersonEnrollment from appearing in two batches * Update app/jobs/get_usps_proofing_results_job.rb Good suggestion, I broke it there because of the linting, but this is easier to read. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * minor refactor to increase readability * rebuild column with corrected name in new migration --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* amendment for PR 8940 to refactor backup codes analytics * changelog: Internal, Analytics, refactor backup codes event logging * move referer to its own method * add in expected properties as string to @param * fix analytics param * fix build error
changelog: Bug Fixes, Sign Out, Remove internal uses of GET-based logout route
…mation page (#8976) * lg-10084 update translations * changelog: User-Facing Improvements, Translations, Update Verify heading in Spanish and French, update idv form fields in Spanish
…8991) * Move redo_document_capture from flow_session to idv_session We are removing attributes from flow_session now that we are not using the Flow State Machine. The redo_document_capture attribute is used to track when someone clicks to redo document capture in VerifyInfo after a barcode read error. [skip changelog] * Replace uses of flow_session['redo_document_capture'] also
…rs to minutes (#9000) changelog: Internal, Configuration, Switch AAL2 remembered device expiration configuration units from hours to minutes
soniaconnolly
approved these changes
Aug 15, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. (I edited the Summary to remove the double message for a couple of commits.)
mitchellhenke
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal