Kmas lg 10488 add missing analytics

[kevinsmaster5]

🎫 Ticket

LG-10488

🛠 Summary of changes

Added analytics methods for when a user visits Add Email Address, Edit Password, and Regenerate Backup Codes pages

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Create an account and log in
• From the user dashboard visit any of those pages
• Event log should show those visits.

[aduth]

Can we add some test coverage for places where we're expecting analytics to be logged?

[aduth]

This screen can be visited in the account creation flow. Per the AC of the ticket, can we ensure that we have a way to differentiate whether the user is regenerating backup codes from the account dashboard vs. account creation?

Account Creation:

1. Go to http://localhost:3000
2. Click Create an account
3. Create an account up to MFA selection
4. Choose Backup codes
5. Continue up to "You’ve added your first authentication method!" screen
6. Click "Skip for now"
7. Click "I need new backup codes"
8. This event would be logged, and I should be able to query distinct from existing account

Existing Account:

1. Go to http://localhost:3000
2. Sign in with an existing account
3. From the account dashboard, click "Get backup codes"
4. This event would be logged, and I should be able to query distinct from account creation

[kevinsmaster5]

That should now be attached to the event by way of
{"event_properties":{"request_came_from":"accounts#show"}...}
{"event_properties":{"request_came_from":"users/backup_code_setup#confirm_backup_codes"}

[aduth]

Couple minor notes, but overall LGTM

[aduth]

Can we prefix this with analytics_ to be clear that these values are related to analytics? Also for consistency with how similar methods are named elsewhere (though there's a fair bit of existing inconsistency between calling it analytics_arguments vs. analytics_properties 😅 ).

[aduth]

Can we list out the specific properties we're expecting here, and document them in the method (YARD) documentation? So that it's clear what it's logging and can be included in the handbook analytics events documentation.

Suggested change

	def backup_code_regenerate_visit(**properties)
	# @param [String] request_came_from the controller/action the request came from
	def backup_code_regenerate_visit(request_came_from:, **extra)

[aduth]

Can we have a real string here rather than anything ? I'd only expect to see anything if the value was rather unpredictable.