Handle unexpected ArcGIS response body#8970
Merged
tomas-nava merged 6 commits intomainfrom Aug 9, 2023
Merged
Conversation
added 5 commits
August 9, 2023 13:10
keeps us consistent with the location controller
changelog: Internal, In-person proofing, Handle a malformed response body from ArcGIS service
zachmargolis
reviewed
Aug 9, 2023
zachmargolis
approved these changes
Aug 9, 2023
| else | ||
| :internal_server_error | ||
| end | ||
| when Faraday::Error, |
Contributor
There was a problem hiding this comment.
personally, I like the less-indented version of this the case/when statements, I'm guessing our rubocop allows both
Contributor
Author
There was a problem hiding this comment.
You wrote the statements I'm changing here :) Yes, rubocop allows both, and I find the left-justfied version confusing.
Contributor
There was a problem hiding this comment.
if rubocop allows both, author's choice I think (until we can figure out how to get it to enforce one or the other)
allthesignals
approved these changes
Aug 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Handles an unexpected response body from the ArcGIS service.
Also:
422instead of a400for most errors inIdv::InPerson::AddressSearchController, to stay consistent withIdv::InPerson::UspsLocationsController– ac41738📔 Notes