Remove internal uses of GET-based logout route#8998
Merged
mitchellhenke merged 1 commit intomainfrom Aug 14, 2023
Merged
Conversation
changelog: Bug Fixes, Sign Out, Remove internal uses of GET-based logout route
zachmargolis
approved these changes
Aug 14, 2023
aduth
reviewed
Aug 14, 2023
| <%= link_to cancel_link_text, sign_up_cancel_path, method: :get, class: 'usa-button usa-button--unstyled' %> | ||
| <% else %> | ||
| <%= link_to cancel_link_text, link || return_to_sp_cancel_path %> | ||
| <% if defined?(link_method) %> |
Contributor
There was a problem hiding this comment.
Wonder if this might have been a good candidate for the button_or_link_to helper.
identity-idp/app/helpers/link_helper.rb
Line 17 in 0579d71
The usa-button--unstyled logic isn't handled there, but (a) maybe it should be or (b) maybe it's fine to apply usa-button--unstyled to a link.
Contributor
Author
There was a problem hiding this comment.
The helper did come up while I was working on it, but it initially seemed like it would be more effort to make the helper work for this case.
Somewhat related, but I'd also like to re-work some of this template too
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Back in #6436 and based on discussion in this thread, we added a DELETE logout route with the intention of switching usage to it, but never changed over.
This PR switches all of our internal usage to the DELETE form, and adds a config for disabling the usage of the GET route.