Log user authentication status when logging SAML Auth Request#8997
Merged
mitchellhenke merged 2 commits intomainfrom Aug 14, 2023
Merged
Log user authentication status when logging SAML Auth Request#8997mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
added 2 commits
August 11, 2023 16:19
changelog: Internal, Logging, Log user authentication status when logging SAML Auth Request
zachmargolis
approved these changes
Aug 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We added some additional attributes to OIDC auth requests and ensure they are logged consistently in #8684 and #8798. This PR takes a similar approach to SAML auth requests by moving the logging before a few of the other
before_actioncalls. Moving it prior to thesign_out_if_forceauthn_is_true_and_user_is_signed_incall allows us to loguser_fully_authenticatedlike we do for OIDC to better understand the impact of ForceAuthn usage.