LG-8034: Redundant enrollment rebase#8853
Merged
racingspider merged 11 commits intomainfrom Aug 14, 2023
Merged
Conversation
… appearing in two batches
… appearing in two batches
tomas-nava
changed the title
Contributor
Author
|
another change came in requiring fixing some merge conflicts. |
Good suggestion, I broke it there because of the linting, but this is easier to read. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Contributor
Author
|
Updated schema.db to latest. |
racingspider
requested review from
NavaTim,
sheldon-b,
tomas-nava and
zachmargolis
NavaTim
reviewed
Aug 8, 2023
zachmargolis
reviewed
Aug 8, 2023
sheldon-b
reviewed
Aug 11, 2023
svalexander
reviewed
Aug 11, 2023
svalexander
reviewed
Aug 11, 2023
sheldon-b
reviewed
Aug 11, 2023
sheldon-b
reviewed
Aug 11, 2023
NavaTim
approved these changes
Aug 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8034
🛠 Summary of changes
Add a new column to set the batch time of InPersonEnrollment to reduce the chance of a redundant batch of enrollments.
Add logic to set the batch time when the InPersonEnrollment is picked up in a batch instead of relying on when it was actually processed.
Change log
changelog: Internal, IPP Enrollments, prevent InPersonEnrollment from appearing in two batches