Skip to content

LG-10084 Update French and Spanish translations for Verify your information page#8976

Merged
gina-yamada merged 4 commits intomainfrom
gyamada/LG-10084-Update-Translations
Aug 14, 2023
Merged

LG-10084 Update French and Spanish translations for Verify your information page#8976
gina-yamada merged 4 commits intomainfrom
gyamada/LG-10084-Update-Translations

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Aug 10, 2023

🎫 Ticket

LG-10084 Update French and Spanish translations for Verify your information page

🛠 Summary of changes

  1. Update this text [[[h1]]] "Vérifier votre information" to this new text [[[h1]]] "Vérifier votre informations"
    🔔 NOTICE: This change affects both /fr/verify/in_person/verify_info and /fr/verify/verify_info
  2. Update text [[[h1]]] “Verifica tus datos” to [[[h1]]]“Verifique sus datos”
    🔔 NOTICE: This change affects both /es/verify/in_person/verify_info and /es/verify/verify_info
  3. Update the component "Nombre de pila" to "Nombre"
    🔔 NOTICE: This change affects /es/verify/in_person/verify_info, /es/verify/verify_info, and /es/verify/document_capture
  4. Update the component "Número de cédula" to "Número de identidad"
    NOTICE: This change only affects /es/verify/in_person/verify_info

📜 Testing Plan

  • Step 1 Create an account
  • Step 2 Go to /verify, upload state-issued ID (front + back) to fail ID verification, go to in person proofing
    Fill in State-Id information, Residential Address, and SSN and continue until you land on /verify/in_person/verify_info.
  • Step 3 Change the url to /fr/verify/in_person/verify_info and inspect the pages for changes ( see 1 in Summary of Changes above)
  • Step 4 Change the url to /es/verify/in_person/verify_info and inspect the pages for changes (see 2, 3, and 4 in Summary of Changes above)
  • Step 5 Cancel and start over. Upload an image (front + back) to pass ID verification to be taken to the remote flow, enter your SSN and continue until you land on /verify/verify_info.
  • Step 6 Change the url to /fr/verify/verify_info and inspect the pages for changes ( see 1 in Summary of Changes above)
  • Step 7 Change the url to /es/verify/verify_info and inspect the pages for changes (see 2 and 3 in Summary of Changes above)
  • Step 8 Cancel and start over.
  • Step 9 Once you are on /verify/hybrid_handoff change the url to /es/verify/hybrid_handoff
  • Step 10 Upload an image to cause a barcode error to be taken /es/verify/document_capture and inspect the pages for changes (see 3 in Summary of Changes above)

*Note: Ticket said Ensure experience works for FSM/non-FSM versions - We currently only have one verion, the non-FSM version

👀 Screenshots

After Summary of changes 1

after /fr/verify/in_person/verify_info

Screenshot 2023-08-10 at 9 38 09 AM

after /fr/verify/verify_info

Screenshot 2023-08-10 at 9 50 20 AM

After Summary of changes 2, 3, 4

after /es/verify/in_person/verify_info

Screenshot 2023-08-10 at 9 49 31 AM

after /es/verify/verify_info

Screenshot 2023-08-10 at 9 50 43 AM

after /es/verify/document_capture

Screenshot 2023-08-10 at 10 58 22 AM

@gina-yamada
Copy link
Contributor Author

gina-yamada commented Aug 10, 2023

Hi @carmenrosalop The changes in this ticket not only affect the In Person Proofing Verify view but also the Verify view for Remote Proofing (Team Ada's flow) and also one view in Document Capture. I took a screen shot of every place affected and provided a URL. I also made a note above in the description with the 🔔 to alert you to the changes outside of IPP. Please let me know if you approve all of these updates. I will let you confirm with the other team we are okay to proceed. Please reach out on Slack if you want to me demonstrate the changes to you locally. Thank you

@svalexander
Copy link
Contributor

I see your note about these changes impacting team Ada's flow so I'll wait to approve after confirmation if that's fine. Otherwise the changes look good.

@gina-yamada gina-yamada requested a review from a team August 11, 2023 17:57
@gina-yamada
Copy link
Contributor Author

gina-yamada commented Aug 11, 2023

French step navigation translation was handled in LG-10087- here is a screenshot after pulling in main after that was merged in. (Same for Spanish step nav- all handled in separate issue so screenshots above don't reflect it as they had not been merged into main when I took the photos above)

Screenshot 2023-08-11 at 1 57 52 PM

@carmenrosalop
Copy link

@gina-yamada the changes look good! I've also checked in with Team Ada and they agreed to these changes.

Copy link

@carmenrosalop carmenrosalop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also Team Ada is aware of these changes. Thanks!

@gina-yamada gina-yamada requested review from a team and svalexander and removed request for svalexander August 14, 2023 16:14
Copy link
Contributor

@sheldon-b sheldon-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gina-yamada gina-yamada merged commit 0579d71 into main Aug 14, 2023
@gina-yamada gina-yamada deleted the gyamada/LG-10084-Update-Translations branch August 14, 2023 17:48
@jmdembe jmdembe mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants