Switch AAL2 remembered device expiration configuration units from hours to minutes#9000
Merged
mitchellhenke merged 1 commit intomainfrom Aug 14, 2023
Conversation
…rs to minutes changelog: Internal, Configuration, Switch AAL2 remembered device expiration configuration units from hours to minutes
zachmargolis
approved these changes
Aug 14, 2023
mitchellhenke
deleted the
mitchellhenke/switch-aal-2-remembered-device-to-minutes
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
In #8926, we switched the default to 0 hours, which is now consistent in all live environments. However, using hours as the unit of time is limiting. NIST 800-63B specifies one of the AAL2 re-authentication limits as 30 minutes, which we would not be able to do at the moment. We do not have any timeline for changing the value from zero, but this PR switches the unit of time to minutes to give us flexibility moving forward.