LG-10438: Start moving document_capture_session_uuid from flow_session to idv_session#8906
Merged
LG-10438: Start moving document_capture_session_uuid from flow_session to idv_session#8906
Conversation
soniaconnolly
approved these changes
Jul 31, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! I did a search and didn't find any other instances of document_capture_session_uuid that need to change.
matthinz
force-pushed
the
matthinz/10438-doc-capture-uuid
branch
2 times, most recently
from
48b386b to
e14d47f
Compare
…ller if available
- Don't inject a flow_session anymore (since we're not using it) - Don't specifically test that uuid in SMS message is the doc capture session uuid (that assertion exists in the controller spec now)
Acuant vars are _not_ added if the document_capture_session_uuid is blank. Since we're storing it in idv_session rather than flow_session, it's now available during these tests, resulting in Acuant A/B test vars now being present on events.
matthinz
force-pushed
the
matthinz/10438-doc-capture-uuid
branch
from
e14d47f to
b076b44
Compare
matthinz
added a commit
that referenced
this pull request
Aug 4, 2023
Following up on #8906, remove references to the flow_session variable [skip changelog]
matthinz
added a commit
that referenced
this pull request
Aug 9, 2023
* Remove references to flow_session[:document_capture_session_uuid] Following up on #8906, remove references to the flow_session variable [skip changelog] * Remove flow_session from CaptureDocStatusController Barcode attention stuff is stored in IdvSession now, so this should be ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10438
🛠 Summary of changes
This is part of an ongoing effort to move IdV data from
flow_sessionand intoidv_sessionnow that we are moving away from the flow state machine.This PR:
idv_session.document_capture_session_uuidalongsideflow_session[:document_capture_session_uuid].idv_session.document_capture_session_uuidwhen reading, but falls back toflow_session[:document_capture_session_uuid]A future PR will remove references to
flow_session[:document_capture_session_uuid], but that will have to wait until this is deployed to be merged.