LG-10593 Move redo_document_capture from flow_session to idv_session#8991
Merged
soniaconnolly merged 2 commits intomainfrom Aug 14, 2023
Merged
Conversation
We are removing attributes from flow_session now that we are not using the Flow State Machine. The redo_document_capture attribute is used to track when someone clicks to redo document capture in VerifyInfo after a barcode read error. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10593
🛠 Summary of changes
We are removing attributes from flow_session now that we are not using the Flow State Machine. The
redo_document_captureattribute is used to track when someone clicks to redo document capture in VerifyInfo after a barcode read error.Both the idv_session and flow_session values are being written and read in this PR to cover the 50/50 state during deployment. A followup PR #8992 will remove all references to
flow_session[:redo_document_capture]andflow_session['redo_document_capture']. (flow_session is a hash with indifferent access)📜 Testing Plan