LG-10050: Prevent MFA setup validation error from persisting#8984
Merged
LG-10050: Prevent MFA setup validation error from persisting#8984
Conversation
changelog: Bug Fixes, MFA Setup, Fix issue where missing selection error message lingered longer than expected
mitchellhenke
approved these changes
Aug 11, 2023
Contributor
mitchellhenke
left a comment
There was a problem hiding this comment.
Hm, this is another one that would have been caught by Rails/ActionControllerFlashBeforeRender
Was mentioned in #8961, but not enabled due to false positives. Maybe we should consider enabling it?
305113e to
f7bba6c
Compare
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10050
🛠 Summary of changes
Updates validation logic for required MFA selection during account creation to prevent the "You must select an authentication method" from lingering unexpectedly after making a selection.
This includes some general refactoring to validation and error handling logic, to reinforce expectations around the shape and value formats of expected parameters and how (and where) error messages are computed.
The fix itself is using
flash.nowinstead offlashwhere a redirect is not involved.📜 Testing Plan
Before: The error message would persist onto the MFA setup screen.
After: The error message does not persist onto the MFA setup screen.
👀 Screenshots