LG-10337: Update error message when doc classification ≠ state ID#8977
LG-10337: Update error message when doc classification ≠ state ID#8977dawei-nava merged 5 commits intomainfrom
Conversation
…e error message, TrueId.
dawei-nava
requested review from
a team,
eileen-nava and
night-jellyfish
and removed request for
a team
| end | ||
|
|
||
| def doc_type_supported? | ||
| !doc_class_name.present? || ID_TYPE_SLUGS.key?(doc_class_name) || doc_class_name == 'Unknown' |
There was a problem hiding this comment.
Is unknown what's returned if it's a passport or a type of ID that's not a state ID?
There was a problem hiding this comment.
@night-jellyfish , if it's a passport or something else, it should be identified if the document image quality is good.
We can only really say it's not supported if it's clearly identified as an unsupported type.
| expect(response.to_h).to include(address_line2_present: true) | ||
| end | ||
|
|
||
| it 'mark doc type as supported' do |
There was a problem hiding this comment.
Is there a plan to add a test for when a non-supported doc type is submitted (or maybe it exists already)?
There was a problem hiding this comment.
@night-jellyfish, the same logic tested somewhere else, but adding the test anyway.
|
The changes you made to the The inline error message only shows up now for the front image, which looks out of sync with the screenshots from the other PR for LG-10337. I attached a video. InlineErrorOnlyShowsForTopImage.movCould you please update this so that it matches the screenshots from the other PR for LG-10337? (I am also tagging @kellular for a design review. Let me know if you disagree about the inline error messages.) |
@eileen-nava, is your test file only contains one side of classification info? I was wondering what's the acuant behavior of submitting two sides of different documents. (My request for aws ssm access still pending). |
Hi! You're correct, that was the issue. I submitted it with a test file that contained both sides' classification info and saw two inline errors. LGTM. 👍🏻 |
| end | ||
|
|
||
| def classification_info | ||
| # Acuent response has both sides info, here simulate that |
3 participants
🎫 Ticket
LG-10337:Update error message when doc classification is not state ID
🛠 Summary of changes
Check TrueId response.