amendment for PR 8940 to refactor backup codes analytics#8985
Merged
kevinsmaster5 merged 6 commits intomainfrom Aug 14, 2023
Merged
amendment for PR 8940 to refactor backup codes analytics#8985kevinsmaster5 merged 6 commits intomainfrom
kevinsmaster5 merged 6 commits intomainfrom
Conversation
aduth
reviewed
Aug 11, 2023
aduth
reviewed
Aug 14, 2023
kevinsmaster5
deleted the
lg-10488-add-missing-analytics-additional-comment
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few remaining comments on #8940.
In particular this comment: #8940 (comment) there was already an analytics_properties method. I included the call that receives the referring url into the existing method and changed how it gets referenced in analytics_events.rb.