LG-10150: Improve error message for canceled security key#8965
Merged
Conversation
changelog: User-Facing Improvements, Authentication, Update error messages related to security key
zachmargolis
reviewed
Aug 9, 2023
app/controllers/two_factor_authentication/webauthn_verification_controller.rb
Show resolved
Hide resolved
jc-gsa
force-pushed
the
LG-10150-security-key-messaging
branch
from
1833750 to
28a472e
Compare
aduth
reviewed
Aug 10, 2023
jc-gsa
force-pushed
the
LG-10150-security-key-messaging
branch
from
b75d615 to
6f2f131
Compare
This reverts commit 6f2f131.
jc-gsa
force-pushed
the
LG-10150-security-key-messaging
branch
from
7b5a96b to
c24587e
Compare
jc-gsa
force-pushed
the
LG-10150-security-key-messaging
branch
from
c24587e to
8264575
Compare
aduth
approved these changes
Aug 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10150
Note: we may want to improve the English text further. Please see the latest comments on the Jira ticket.
🛠 Summary of changes
Error messages related to using a security key as a MFA option have been changed at two locations: during registration and login.
The two locations where the error messages can be encountered are:
/webauthn_setup(registration)/login/two_factor/webauthn(login)📜 Testing Plan
To get the error messages to display, cancel the security key process (ceremony) during registration or login at the two locations listed above.