LG-10546: make created at unix at form#8922
Conversation
app/controllers/two_factor_authentication/personal_key_verification_controller.rb
Show resolved
Hide resolved
|
This looks like a change to specific analytics fields. I thought you were proposing a more general change that would convert all timestamps. Is this a test for the more general change? |
I'm not familiar with what had been discussed in the engineering huddle, but if we wanted this to be universal, we could consider something which converts date objects to timestamps as part of the serialization logic (in place of |
|
Yea this PR is just a fix for what we specifically were dealing with as a proof of concept for general adoption in a later PR |
|
@zachmargolis wanted your opinion on this PR to see if changing dates to unix could be a way forward for us. with storing DateTime in analytic events, that makes it easier query based on the dates. |
app/controllers/two_factor_authentication/webauthn_verification_controller.rb
Outdated
Show resolved
Hide resolved
af552b4 to
6b5296a
Compare
|
Talked to @aduth And I think for now we can just do opt in option and if we want to make it universal that should be a separate ticket |
🎫 Ticket
LG-10546
🛠 Summary of changes
Change the log to unix time instead of default datetime format since that is not easily queryable in AWS
Screenshot