LG-10438: Remove flow_session[:document_capture_session_uuid]#8907
Merged
LG-10438: Remove flow_session[:document_capture_session_uuid]#8907
Conversation
matthinz
force-pushed
the
matthinz/10438-doc-capture-uuid
branch
3 times, most recently
from
e14d47f to
b076b44
Compare
Following up on #8906, remove references to the flow_session variable [skip changelog]
matthinz
force-pushed
the
matthinz/10438-remove-flow-session-dcu
branch
from
a43e3db to
259f829
Compare
Barcode attention stuff is stored in IdvSession now, so this should be ok?
matthinz
commented
Aug 4, 2023
|
|
||
| def status | ||
| @status ||= begin | ||
| if !flow_session || !document_capture_session |
Contributor
Author
Contributor
There was a problem hiding this comment.
Nope, I think it is safe for this to be removed
Contributor
Author
|
(Gonna hold off on merging this until after next deploy) |
jmhooper
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10438
🛠 Summary of changes
Remove references to
flow_session[:document_capture_session_uuid]after the variable was moved toidv_sessionin #8906.