Prepare Release by github-actions[bot] · Pull Request #833 · typed-ember/glint

github-actions · 2025-03-23T17:09:26Z

This PR is a preview of the release that release-plan has prepared. To release you should just merge this PR 👍

Release (2025-06-16)

@glint/core 2.0.0-alpha.1 (major)
@glint/environment-ember-loose 2.0.0-alpha.1 (major)
@glint/environment-ember-template-imports 2.0.0-alpha.1 (major)
@glint/template 1.6.0-alpha.0 (major)
@glint/tsserver-plugin 2.0.0-alpha.1 (major)
@glint/type-test 2.0.0-alpha.1 (patch)

💥 Breaking Change

@glint/core, @glint/environment-ember-loose, @glint/environment-ember-template-imports, @glint/template
- #820 Drop support for @types/ember* only use native/built-in types (@NullVoxPopuli)
@glint/core, @glint/tsserver-plugin
- #811 Migrate tests to TS Plugin mode, remove option for old LS mode (@machty)
Other
- #790 Re-write extension to use reactive-vscode, align with Vue extension (@machty)
@glint/core
- #750 Rm TransformManager and lots of pre-volar code (@machty)
- #740 Fix glint cli build tests, parity with vue-tsc (@machty)
- #739 rm glint/getIR command (@machty)
@glint/environment-ember-loose
- #721 feat: drop support for classic component layout (@aklkv)
@glint/core, @glint/environment-ember-loose, @glint/environment-ember-template-imports
- #726 Re-write using Volar: initially only supporting .gts (@machty)
@glint/core, @glint/template
- #716 Remove GlimmerX (@machty)

🚀 Enhancement

Other
- #895 VSCode: Add activationEvents for glimmer-ts/js file types (@machty)
- #803 Use jiti for sync loading from TS Plugin (@machty)
- #791 Monkeypatch remaining TS features within .gts files (@machty)
@glint/core, @glint/tsserver-plugin
- #890 Move .gts/.gjs import hacks to TS Plugin (@machty)
- #877 Reinstate GJS Support (@machty)
- #873 Disregard semantic classification tokens from <template> portions of .gts files (@machty)
@glint/core
- #888 Restore previous approach to glint-* directives atop new TS Plugin architecture (@machty)
- #876 Support for Symbols, Outline, Code Folding in .gts files (@machty)
- #874 Fix organize imports (@machty)
- #856 Support (neo)vim filetypes for gts and gjs (@NullVoxPopuli)
- #854 Loose mode: only parse .ts in components/ folder (@machty)
- #838 Support extending multiple config files (@mogstad)
- #839 use more specific nodes for open tag (@patricklx)
- #813 Cleanup old LS remainders, disable CLI tests for now, rm ephemeral tests (@machty)
- #749 Primitives for supporting ember-loose mode (.ts + .hbs) (@machty)
- #747 volar-2.4.0-alpha.14 (@machty)
- #713 check if template is in heritage clause (@patricklx)
@glint/core, @glint/template, @glint/tsserver-plugin
- #849 add html attribute validation & completions (@patricklx)
@glint/core, @glint/environment-ember-loose, @glint/environment-ember-template-imports, @glint/template
- #753 TS Plugin: basic diagnostics and functionality for .gts files (@machty)
@glint/core, @glint/environment-ember-loose, @glint/environment-ember-template-imports
- #726 Re-write using Volar: initially only supporting .gts (@machty)

🐛 Bug Fix

@glint/template
- #903 @glint/template: Fix Element extends comparison (@NullVoxPopuli)
- #880 fix missing generic attrs for svg (@patricklx)
@glint/core, @glint/tsserver-plugin
- #889 Reinstate "unused @glint-expect-error directive" (@machty)
@glint/core
- #865 Prefer variables in scope over global variables (@mogstad)
- #861 Inject hidden imports to fix .gts/.gjs extensions (@machty)
- #851 Refrain creating ember-loose virtual code in non ember-loose environment (@mogstad)
- #809 Bump volar to 2.4.12, fix caching issue w loose mode (@machty)
- #799 Reinstate glint-expect-error (and other directives) for tsc and TS Plugin using Vue's approach (@machty)
- #795 Restore "unused glint-expect-error" diagnostic (@machty)
- #794 Reinstate expect-error directives for .gts (@machty)
- #783 Suppress exception thrown by require.resolve if the file does not exist (@iarroyo)
- #782 Typed ember/resolve config from extends package (@iarroyo)
- #779 Closes #778 - add missing dependency to @glint/core (@NullVoxPopuli)
Other
- #866 enable completions in vscode (@patricklx)
- #858 Disable esModuleInterop to restore VSCode monkeypatching (@machty)
@glint/environment-ember-template-imports
- #859 Fix handling of satisfies on components. (@NullVoxPopuli)
@glint/core, @glint/environment-ember-template-imports
- #842 Improve multi-byte character handling (@NullVoxPopuli)
- #825 Support implicit default export of template tags with satisfies keyword (@mogstad)
@glint/tsserver-plugin
- #829 Fix VSCode extension pre-release (@machty)
@glint/environment-ember-loose
- #826 Explicitly accept an Iterable in each-in (@mogstad)
- #777 Widen peerDependencies to allow @glimmer/component v2 (@SergeAstapov)

📝 Documentation

Other
- #872 Remove export default from the Template-only components example (@Windvis)
- #850 Update info about not disabling the @builtin typescript extension forV2 (@johanrd)
- #847 Update GLINT_V2.md with updated information (@johanrd)
- #836 Update GLINT_V2.md readme (@johanrd)
- #832 Update Glint v2 docs (@NullVoxPopuli)
- #827 Update ARCHITECTURE and GLINT_V2 docs (@machty)
- #822 Add a few docs about vscode extension monkeypatches (@machty)
- #821 Simplify the TO template tag example (@Windvis)
- #786 Clarify typing for no arguments/blocks (@elwayman02)
@glint/type-test
- #725 docs: use gjs as codefence lang (@IgnaceMaes)

🏠 Internal

@glint/template
- #907 Fix @glint/template version to match with what's released (@NullVoxPopuli)
- #906 Switch to preminor for @glint/template (@NullVoxPopuli)
- #881 Consolidate scripts, add generated files to eslint/prettier ignore file (@NullVoxPopuli)
- #855 Extract type-tests from @glint/template that cause dependency problems to their own package (@NullVoxPopuli)
@glint/core, @glint/environment-ember-loose, @glint/environment-ember-template-imports, @glint/tsserver-plugin, @glint/type-test
- #902 Setup alpha releases (@NullVoxPopuli)
- #818 Migrate to pnpm (@NullVoxPopuli)
Other
- #892 Remove grammars (@evoactivity)
- #893 Remove deprecated F5 launch configurations (@machty)
- #894 Fix broken main test (@machty)
- #862 Use the tars directly, rather than links (@NullVoxPopuli)
- #852 rm test.only() (@machty)
- #834 Make the test-apps private (@NullVoxPopuli)
- #831 Setup release-plan for releases (@NullVoxPopuli)
- #807 Introduce smoke test for TS Plugin + Loose Mode (@machty)
- #805 Easy F5 testability of loose+gts ember app (@machty)
- #789 Single acceptance test for ts plugin mode (@machty)
- #744 Disable red CI for now (@machty)
- #743 skip vscode tests (@machty)
- #735 Fix Windows snapshots (@machty)
- #727 Setup unstable releases (@NullVoxPopuli)
@glint/environment-ember-template-imports
- #883 Add character tests (@NullVoxPopuli)
@glint/environment-ember-loose, @glint/environment-ember-template-imports, @glint/type-test
- #857 Setup external project linking / testing (@NullVoxPopuli)
@glint/core
- #843 Move core tests out of core package due to tests depending on packages that depend on core (@NullVoxPopuli)
- #809 Bump volar to 2.4.12, fix caching issue w loose mode (@machty)
- #788 Reinstate acceptance tests (gts) (@machty)
- #784 Upgrade to Volar 2.4.11 (@machty)
- #759 Fix prettier issues (@machty)
- #752 TS Plugin progress, bump volar (@machty)
- #751 TS Plugin WIP - restore green tests (@machty)
- #747 volar-2.4.0-alpha.14 (@machty)
- #746 Unskip/fix almost every test that doesn't require code changes (@machty)
- #745 Pass a few more build tests (@machty)
- #742 get a few composite tests passing (@machty)
- #741 Tests: Use clearer project testing commands (@machty)
@glint/core, @glint/environment-ember-loose, @glint/environment-ember-template-imports, @glint/template, @glint/type-test
- #731 Split typechecking from tests (@NullVoxPopuli)
@glint/core, @glint/environment-ember-loose
- #729 Most of the way to green tests (@machty)

Committers: 12

Alex Matchneer (@machty)
Alexey Kulakov (@aklkv)
Bjarne Mogstad (@mogstad)
Ignace Maes (@IgnaceMaes)
Ivan Arroyo Escobar (@iarroyo)
Jordan Hawker (@elwayman02)
Liam Potter (@evoactivity)
Patrick Pircher (@patricklx)
Sam Van Campenhout (@Windvis)
Sergey Astapov (@SergeAstapov)
@NullVoxPopuli
@johanrd

NullVoxPopuli

[NOT READY FOR MERGE]

(as of 2025-03-23)

We don't want @glint/template to release as a major version bump.

I don't think any meaningful changes have actually happened within it, but it probably got caught up in wide-sweeping changes that are breaking in the same PR.

When we're ready to release, we'll need to hand-edit the .release-plan.json and @glint/template/package.json to change the version bump to be a minor release.

NullVoxPopuli · 2025-03-23T17:34:29Z

oh actually, it is breaking. because we dropped support for GlimmerX and formal support for DT Types.

HMMM. projects that already include @glint/template @ v1, may need to use an override to move to v2, as @glint/template has things that will not allow a second copy to exist and be compatible with @glint/core (the brand/symbol types, specifically)

patricklx · 2025-03-23T19:32:32Z

Also, ts-plugin-test-app needs to be private
@NullVoxPopuli

NullVoxPopuli · 2025-03-23T20:30:19Z

fixed @patricklx 🎉

NullVoxPopuli

Re: declared "breaking" changes in @glint/template

only comments: https://github.com/typed-ember/glint/pull/716/files#diff-2da8504290f080a9d0d2ab0820be3a8d4ff6dbce684b3ae65ca216d8d85c7f15L30
just removed a dependencies entry on a @types: https://github.com/typed-ember/glint/pull/820/files#diff-db9c93b67e37a1ca885c6ecaba477c13d3a487a4dabab5a740bb6212def2554dL21
- this isn't breaking because our whole ecosystem relies on peer-provided types.

So, I'm going to manually tell @glint/template to be a patch release, rather than a major (it's declared as a major due to basically re-writing Glint, which resulted in some sloppy git practices).

However!!!!
Here is a test of @glint/template@unstable (tracking every main commit) against a project that was previously using @glint/template@^1.5: universal-ember/ember-primitives#491

It's currently failing. Which means "something" did break something. We need to fix this, because we don't want to release a major of @glint/template, ideally -- since many packages depend on it -- we don't want to force a release that expands their version range to || ^2.0.0-alpha.0 if we don't have to.

In particular, it looks like our element subclassing is failing?

src/components/keys.gts:34:51 - error TS2345: Argument of type 'HTMLSpanElement' is not assignable to parameter of type 'HTMLElement'.
  Types of property '[GlintSymbol]' are incompatible.
    Type '"HTMLSpanElement"' is not assignable to type '"HTMLElement"'.

 34   <span class="ember-primitives__key-combination" ...attributes>

and

src/components/menu.gts:175:7 - error TS2345: Argument of type 'HTMLDivElement' is not assignable to parameter of type 'HTMLElement'.
  Types of property '[GlintSymbol]' are incompatible.
    Type '"HTMLDivElement"' is not assignable to type '"HTMLElement"'.

175       {{installContent isOpen=@isOpen triggerElement=@triggerElement}}
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

where this modifier has specified HTMLElement, and the element that the modifier is on is a HTMLDivElement. This should be allowed because HTMLElement is saying "I take any HTML".

mansona · 2025-06-16T08:31:12Z

shouldn't @glint/template also be a pre-release here?

NullVoxPopuli · 2025-06-16T13:12:49Z

Template has a bug which is blocking any releasing right now

#833 (review)

See: #903

There is some discussion in discord about this, too, iirc

NullVoxPopuli · 2025-06-16T23:47:37Z

Thanks to @mansona, our alpha versions look good.

All publishable packages will be alpha as of the merge of this PR.

The goal:

@glint/template should be compatible with all existing code, and the new glint (it's just types, and not related exactly to the language server stuff)
Test out the other @glint/* packages for the next-gen / v2 glint stuff, which is Volar powered

Bugfixed

github-actions Bot added the internal Changes that don't impact the published packages label Mar 23, 2025

github-actions Bot force-pushed the release-preview branch from 1afbaab to 3dbadc5 Compare March 23, 2025 17:24

NullVoxPopuli requested changes Mar 23, 2025

View reviewed changes

github-actions Bot force-pushed the release-preview branch from 3dbadc5 to 6c240bd Compare March 23, 2025 19:49

github-actions Bot force-pushed the release-preview branch 17 times, most recently from 76a7b0a to 4008d7a Compare March 28, 2025 21:41

github-actions Bot force-pushed the release-preview branch 6 times, most recently from dd8f645 to 1a655bc Compare April 2, 2025 15:17

github-actions Bot force-pushed the release-preview branch 4 times, most recently from f62ea84 to 40cb70d Compare April 7, 2025 02:54

github-actions Bot force-pushed the release-preview branch 10 times, most recently from 7b64361 to 891a959 Compare April 16, 2025 17:54

github-actions Bot force-pushed the release-preview branch from 891a959 to fd4daa4 Compare May 7, 2025 21:33

github-actions Bot force-pushed the release-preview branch from fd4daa4 to 12df346 Compare June 10, 2025 15:59

NullVoxPopuli previously requested changes Jun 10, 2025

View reviewed changes

NullVoxPopuli mentioned this pull request Jun 10, 2025

@glint/template: Fix Element extends comparison #903

Merged

github-actions Bot force-pushed the release-preview branch 2 times, most recently from 3e0d833 to d9e0fe5 Compare June 16, 2025 23:40

Prepare Release using 'release-plan'

b491f6b

github-actions Bot force-pushed the release-preview branch from d9e0fe5 to b491f6b Compare June 16, 2025 23:46

NullVoxPopuli merged commit 214df84 into main Jun 16, 2025
2 checks passed

NullVoxPopuli deleted the release-preview branch June 16, 2025 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare Release#833

Prepare Release#833
NullVoxPopuli merged 1 commit intomainfrom
release-preview

github-actions Bot commented Mar 23, 2025 •

edited

Loading

Uh oh!

NullVoxPopuli left a comment •

edited

Loading

Uh oh!

NullVoxPopuli commented Mar 23, 2025

Uh oh!

patricklx commented Mar 23, 2025 •

edited

Loading

Uh oh!

NullVoxPopuli commented Mar 23, 2025

Uh oh!

NullVoxPopuli left a comment •

edited

Loading

Uh oh!

mansona commented Jun 16, 2025

Uh oh!

NullVoxPopuli commented Jun 16, 2025

Uh oh!

NullVoxPopuli commented Jun 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

github-actions Bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release (2025-06-16)

💥 Breaking Change

🚀 Enhancement

🐛 Bug Fix

📝 Documentation

🏠 Internal

Committers: 12

Uh oh!

NullVoxPopuli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli commented Mar 23, 2025

Uh oh!

patricklx commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NullVoxPopuli commented Mar 23, 2025

Uh oh!

NullVoxPopuli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mansona commented Jun 16, 2025

Uh oh!

NullVoxPopuli commented Jun 16, 2025

Uh oh!

NullVoxPopuli commented Jun 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Mar 23, 2025 •

edited

Loading

NullVoxPopuli left a comment •

edited

Loading

patricklx commented Mar 23, 2025 •

edited

Loading

NullVoxPopuli left a comment •

edited

Loading