Support implicit default export of template tags with satisfies keyword#825
Merged
NullVoxPopuli merged 1 commit intotyped-ember:mainfrom Mar 21, 2025
Merged
Conversation
NullVoxPopuli
approved these changes
Mar 21, 2025
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Makes sense, thank you!
Contributor
Author
|
I think upgrading to content-tag v3 would solve the test issue, any reason not to upgrade it? |
Contributor
|
We should use content-tag v3, but probably in a different PR. My next batch of work in this repo is converting to pnpm so deps make sense, which may help us with the error received here (if it still exists), and figuring out the TS config incantation to resolve |
mogstad
force-pushed
the
push-qqokvslpkksk
branch
from
8f36fae to
41540ae
Compare
| // | ||
| // https://github.com/embroider-build/content-tag/blob/v1.2.2-content-tag/package.json#L13-L21 | ||
| // | ||
| // @ts-expect-error see above |
Contributor
There was a problem hiding this comment.
can you re-add this block comment for now?
mogstad
force-pushed
the
push-qqokvslpkksk
branch
from
41540ae to
beec8f9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try resolving #824